-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenStack to ObserveCloudProviderNames #135
Add OpenStack to ObserveCloudProviderNames #135
Conversation
Running the operator on OpenStack currently results in "No recognized cloud provider platform found in cloud config". This adds `openstack` to the switch statement alongside libvirt and aws.
@eparis @crawford @wking Does this need an exception? Or can it be considered a bug fix? It should unblock openshift/installer#1092 |
We want this for openshift/installer#1107, which we want for openshift/installer#792, which is certainly a bug, so I'm comfortable calling this a bugfix. |
@wking thanks! I can also confirm that this fixes OpenStack's deployment. |
Approving based on @wking feedback! /lgtm |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, ingvagabund, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Running the operator on OpenStack currently results in "No recognized
cloud provider platform found in cloud config". This adds
openstack
to the switch statement alongside libvirt and aws.