Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenStack to ObserveCloudProviderNames #135

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add OpenStack to ObserveCloudProviderNames #135

merged 1 commit into from
Jan 28, 2019

Conversation

tomassedovic
Copy link
Contributor

Running the operator on OpenStack currently results in "No recognized
cloud provider platform found in cloud config". This adds openstack
to the switch statement alongside libvirt and aws.

@tomassedovic
Add OpenStack to ObserveCloudProviderNames
4e96c18 
Running the operator on OpenStack currently results in "No recognized
cloud provider platform found in cloud config". This adds `openstack`
to the switch statement alongside libvirt and aws.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2019
@flaper87
Copy link
Contributor

@eparis @crawford @wking Does this need an exception? Or can it be considered a bug fix?

It should unblock openshift/installer#1092

@wking
Copy link
Member

wking commented Jan 28, 2019

We want this for openshift/installer#1107, which we want for openshift/installer#792, which is certainly a bug, so I'm comfortable calling this a bugfix.

@flaper87
Copy link
Contributor

@wking thanks!

I can also confirm that this fixes OpenStack's deployment.

@flaper87
Copy link
Contributor

Approving based on @wking feedback!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@flaper87
Copy link
Contributor

/approve

@ingvagabund
Copy link
Member

We want this for openshift/installer#1107, which we want for openshift/installer#792, which is certainly a bug, so I'm comfortable calling this a bugfix.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, ingvagabund, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 09b13a8 into openshift:master Jan 28, 2019
@tomassedovic tomassedovic deleted the openstack branch January 28, 2019 12:28
This was referenced Jan 28, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@flaper87 flaper87

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tomassedovic @flaper87 @wking @ingvagabund @openshift-ci-robot @openshift-merge-robot