Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1812709: Normalize CPU requests on masters #377

Merged
merged 1 commit into from Apr 7, 2020
Merged

[release-4.4] Bug 1812709: Normalize CPU requests on masters #377

merged 1 commit into from Apr 7, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #363

/assign smarterclayton

@smarterclayton
Normalize CPU requests on masters
364a4e2 
The kcm uses approximately 5% of master CPU in a reasonable medium
sized workload. The kcm can be bursty in certain scenarios.

Given a 1 core per master baseline (since CPU is compressible and
shared), assign the kcm roughly 10% of that core on each master
(1/3 of the kube-apiserver usage).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 18, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1812583, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected Bugzilla bug 1812583 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1812583: Normalize CPU requests on masters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 18, 2020
soltysh
soltysh approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@sdodson
Copy link
Member

sdodson commented Mar 23, 2020

/retitle [release-4.4] Bug 1812709: Normalize CPU requests on masters

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1812583: Normalize CPU requests on masters [release-4.4] Bug 1812709: Normalize CPU requests on masters Mar 23, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1812709, which is invalid:

  • expected dependent Bugzilla bug 1812583 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1812709: Normalize CPU requests on masters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8b9522b into openshift:release-4.4 Apr 7, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: . Bugzilla bug 1812709 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1812709: Normalize CPU requests on masters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 8, 2020
Merged
Merged
Merged
@soltysh
Copy link
Member

soltysh commented Apr 14, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link
Author

@soltysh: #377 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	bindata/v4.1.0/kube-controller-manager/pod.yaml
M	pkg/operator/v411_00_assets/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/v411_00_assets/bindata.go
CONFLICT (content): Merge conflict in pkg/operator/v411_00_assets/bindata.go
Auto-merging bindata/v4.1.0/kube-controller-manager/pod.yaml
CONFLICT (content): Merge conflict in bindata/v4.1.0/kube-controller-manager/pod.yaml
Patch failed at 0001 Normalize CPU requests on masters

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @sdodson @openshift-bot @soltysh @smarterclayton @openshift-merge-robot