-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump library-go to migrate controllers to factory #378
bump library-go to migrate controllers to factory #378
Conversation
* openshift/library-go@bfa173d6: set .sh files to be executeable * openshift/library-go@12d0d7cb: Create reusable package to manage manifests for use by CVO and oc * openshift/library-go@a6f04ac3: Set a random serial number for signing certificate templates * openshift/library-go@3a6456f2: resourcemerge: Allow removing annotations/labels * openshift/library-go@4657d563: controller: add manager and wire graceful termination into leader election * openshift/library-go@9a403ca7: resourcesynccontroller: migrate to controller factory * openshift/library-go@423e2029: factory: allow for post-start hooks for custom triggers * openshift/library-go@7c9065e5: implements a generic workload controller * openshift/library-go@522f72df: go mod tidy * openshift/library-go@07fd01b5: adds precondition function * openshift/library-go@34fe6fc1: factory: remove support for runtime object in queue * openshift/library-go@07eabbf2: nsfinalizer: migrate controller to factory * openshift/library-go@488e1fa9: apiservice: migrate controller to factory * openshift/library-go@38b127eb: certrotation: migrate controller to factory * openshift/library-go@3f9a525d: configobserver: migrate controller to factory * openshift/library-go@5f7087d1: management: migrate controller to factory * openshift/library-go@7f456e65: staleconditions: migrate controller to factory * openshift/library-go@f17c0ee0: status: migrate controller to factory * openshift/library-go@892bfb19: resourcesync: adjust to queue key * openshift/library-go@fa685adb: leaderelection: do not fatal on leader election lost * openshift/library-go@c95f7e3a: allows for setting an optional prefix for condition's type field for the generic workload ctrl * openshift/library-go@3e49782f: delegates creation of common informers down to workload controller * openshift/library-go@a43f112d: logging: properly set log level * openshift/library-go@1add03a0: resourcesynccontroller: fix unit test flakes * openshift/library-go@9ff13301: configobserver: pass informers in controller constructor * openshift/library-go@a7e2a0be: certrotation: check the context value for nil * openshift/library-go@1120d68f: removes APIServicesToManage * openshift/library-go@919a2f23: react when the number of node changes for the workload controller * openshift/library-go@cfb65d06: cleans up vendor * openshift/library-go@41b15d9c: factory: fix appending to caches * openshift/library-go@d962da9d: config-observers: prune returned config * openshift/library-go@01cad355: config-observers: unify error handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
module e2e failures
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.