Bug 1842002: use internal LB to avoid outages during kube-apiserver rollout #431
Conversation
openshift-ci-robot
added
the
approved
|
I think this one is enough to fix the endpoints problem. We should move this to library-go if we decide on it for kube-scheduler too |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| t.Fatal(errs) | ||
| } else { | ||
| if !reflect.DeepEqual(test.expected, result) { | ||
| t.Errorf("\n===== observed config expected:\n%v\n===== observed config actual:\n%v", toYAML(test.expected), toYAML(result)) |
There was a problem hiding this comment.
cmp.Diff shows those nicely
|
How does this work when the client kubeconfigs still point to localhost? |
tnozicka
changed the title
|
@deads2k: All pull requests linked via external trackers have merged: openshift/cluster-kube-controller-manager-operator#431. Bugzilla bug 1842002 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This makes us vulnerable to internal LB config that we do not own, but kubelets already break
Doing it like this leverages our existing config observation instead of creating a dynamic kubeconfig handling.
/assign @soltysh @sanchezl @tnozicka