Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1867494: Explicitly use internal LB for KCM and CPC #441

Merged
merged 3 commits into from Sep 3, 2020

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Sep 2, 2020

We should explicitly state which URL are we using instead of the hack with old master config override.
Also this wasn't wired for CPC and validating webhooks before.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1867494 and half of https://bugzilla.redhat.com/show_bug.cgi?id=1861917

/cc @soltysh @deads2k

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2020
@tnozicka tnozicka changed the title [WIP] Bug 1867494,1861917: Explicitly use internal LB for KCM and CPC [WIP] Bug 1867494 1861917: Explicitly use internal LB for KCM and CPC Sep 2, 2020
@tnozicka tnozicka changed the title [WIP] Bug 1867494 1861917: Explicitly use internal LB for KCM and CPC Bug 1867494 1861917: Explicitly use internal LB for KCM and CPC Sep 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2020
@tnozicka tnozicka changed the title Bug 1867494 1861917: Explicitly use internal LB for KCM and CPC Bug 1867494: Bug 1861917: Explicitly use internal LB for KCM and CPC Sep 2, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 2, 2020
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1867494, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867494: Bug 1861917: Explicitly use internal LB for KCM and CPC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka changed the title Bug 1867494: Bug 1861917: Explicitly use internal LB for KCM and CPC Bug 1867494: Explicitly use internal LB for KCM and CPC Sep 2, 2020
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1867494, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867494: Explicitly use internal LB for KCM and CPC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1867494, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867494: Explicitly use internal LB for KCM and CPC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for @deads2k final sign off

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@deads2k
Copy link
Contributor

deads2k commented Sep 3, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d56255f into openshift:master Sep 3, 2020
@openshift-ci-robot
Copy link

@tnozicka: All pull requests linked via external trackers have merged:

Bugzilla bug 1867494 has been moved to the MODIFIED state.

In response to this:

Bug 1867494: Explicitly use internal LB for KCM and CPC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants