collect metrics for cluster-policy-controller #554
Conversation
| @@ -14,3 +14,6 @@ spec: | |||
| - name: https | |||
| port: 443 | |||
| targetPort: 10257 | |||
| - name: httpscpc | |||
| port: 10357 | |||
There was a problem hiding this comment.
should I choose a different port or create a standalone service instead?
There was a problem hiding this comment.
@atiratree double check that with monitoring team, I think you're gonna need a new service or at least a configuration for the 2nd port, since you're not using non-standard 443 here. I think having a service will be simpler.
There was a problem hiding this comment.
I have switched to using 2 services and 2 service monitors to separate the responsibilities
|
/retest |
manifests/0000_90_kube-controller-manager-operator_04_servicemonitor-controller-manager.yaml
Outdated
Show resolved
Hide resolved
|
/retest |
1 similar comment
|
/retest |
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
/assign @ravisantoshgudimetla |
| @@ -14,3 +14,6 @@ spec: | |||
| - name: https | |||
| port: 443 | |||
| targetPort: 10257 | |||
| - name: httpscpc | |||
| port: 10357 | |||
There was a problem hiding this comment.
@atiratree double check that with monitoring team, I think you're gonna need a new service or at least a configuration for the 2nd port, since you're not using non-standard 443 here. I think having a service will be simpler.
atiratree
force-pushed
the
cpc-metrics
branch
from
c8a30e3
to
1cebafd
Compare
|
/retest |
bindata/assets/kube-controller-manager/svc-cluster-policy-controller.yaml
Outdated
Show resolved
Hide resolved
| kube-controller-manager: "true" | ||
| ports: | ||
| - name: https | ||
| port: 443 |
There was a problem hiding this comment.
Do we really need to have the service listening on a privileged port? It might be better to use the same port as the one used by the container wdyt?
There was a problem hiding this comment.
@dgrisonnet I have switched to the respective container ports. Although I am not sure why 443 port is problematic for services, can you elaborate on that a bit?
There was a problem hiding this comment.
I am not aware of any with services, but I tend to avoid using privileged ports as much as possible and here I don't think there is a real reason for that.
atiratree
force-pushed
the
cpc-metrics
branch
from
1cebafd
to
164150f
Compare
|
/retest |
1 similar comment
|
/retest |
|
installer PR merged |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
since this merged, we're seeing a payload promotion failure on See jobs linked from https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/aggregated-aws-ovn-upgrade-4.10-minor-release-openshift-release-analysis-aggregator/1461737712246591488 for example |
| prometheus: kube-controller-manager | ||
| --- | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor |
Revert "Merge pull request #554 from atiratree/cpc-metrics"
updates the ServiceMonitor so it also collects metrics from cluster-policy-controller.
This will start working after the correct ports get opened on the nodes - see installer PR
TODO: