Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-33933: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags #808

Merged
merged 3 commits into from
May 20, 2024
Merged

[release-4.16] OCPBUGS-33933: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags #808

merged 3 commits into from
May 20, 2024

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented May 17, 2024

/hold
until we land #806

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2024 •
edited by openshift-ci bot

@soltysh: This pull request references OCPCLOUD-2513 which is a valid jira issue.

In response to this:

/hold
until we land #806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@JoelSpeed
Copy link
Contributor

/jira cherry-pick https://issues.redhat.com/browse/OCPBUGS-33931

@JoelSpeed JoelSpeed changed the title [release-4.16] OCPCLOUD-2513: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags [release-4.16] OCPBUGS-33933: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags May 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 20, 2024
@openshift-ci-robot
Copy link

@soltysh: This pull request references Jira Issue OCPBUGS-33933, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-33931 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-33931 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/hold
until we land #806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 May 20, 2024 08:19
@JoelSpeed
Copy link
Contributor

Vendor folder appears broken on this branch, will need fixing before we can proceed

soltysh and others added 3 commits May 20, 2024 12:57
@soltysh
bump(openshift/*)
c8d27fa
@nrb @soltysh
Remove cloud provider flags
161017d 
The following flags were removed as they are depecrated and will
eventually create an error when used.

* --cloud-config
* --cloud-provider
* --cloud-volume-plugin
* --configure-cloud-routes

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@soltysh
React to openshift/api changes
9e527bb
@soltysh
Copy link
Member Author

soltysh commented May 20, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soltysh
Copy link
Member Author

soltysh commented May 20, 2024

/hold cancel
/label backport-risk-assessed

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 20, 2024
@zhouying7780
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0338b3b into openshift:release-4.16 May 20, 2024
10 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@soltysh: Jira Issue OCPBUGS-33933: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33933 has been moved to the MODIFIED state.

In response to this:

/hold
until we land #806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh soltysh deleted the bump_deps_416 branch May 20, 2024 13:56
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.16.0-202405201532.p0.g0338b3b.assembly.stream.el9 for distgit ose-cluster-kube-controller-manager-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-21-043355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@kasturinarra kasturinarra

@JoelSpeed JoelSpeed

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@soltysh @openshift-ci-robot @JoelSpeed @zhouying7780 @openshift-bot @openshift-merge-robot @kasturinarra @xingxingxia @nrb