OCPBUGS-33931, OCPCLOUD-2513: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags #806
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@soltysh: This pull request references OCPCLOUD-2513 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
openshift-ci
bot
added
the
approved
|
With the cloud volume plugin completely removed, will this remove the value on upgrades? |
|
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test ? |
|
@JoelSpeed: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade |
|
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a496ffe0-12b3-11ef-8f3e-0db820aded8e-0 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
The changes look good from the KCM-o point of view. Leaving the cloud part check for @JoelSpeed. |
No, looking at the gather from the azure upgrade the cloud volume plugin config is left over. We need to keep the observer and clear the value or include a removal step for this key in the main cloud observer |
|
Have created a commit that should resolve the issue, JoelSpeed@6481e27 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade |
|
@soltysh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d4ddeac0-1366-11ef-8a72-b1fadc630491-0 |
There was a problem hiding this comment.
I believe the issue here is https://github.com/openshift/cluster-kube-controller-manager-operator/pull/806/files#diff-1e1c9f596fa20c6b4f54622a098756ee0d2f7203d19139a58a250c7a7bcb2af4R50-R55
The cloud config observer is clearing the cloud-config configmap, and the KCM pods are complaining that they can't open it.
The KCM pods should get updated to no longer rely on the configmap, but I'm guessing there's some sort of ordering issue here that means that the configmap is being removed, which then breaks the existing KCMs, and prevents the observed config from being updated.
I think the next thing to try is to revert the removal of the configmap and see if the upgrade can continue
These events are repeating throughout the logs. It appears to be trying to remove the config over and over, without success and never settles. So likely also an issue with the config observation code itself |
|
Your reference on previous comment is a bit confusing on the configmap removal part. I think what you meant is this code change https://github.com/openshift/cluster-kube-controller-manager-operator/pull/806/files#diff-1e1c9f596fa20c6b4f54622a098756ee0d2f7203d19139a58a250c7a7bcb2af4 coming from this PR specifically openshift/library-go@b8bcc87. |
|
I opened this PR to test out Joel's theory on reverting the cloud-config configmap deletion. |
The following flags were removed as they are depecrated and will eventually create an error when used. * --cloud-config * --cloud-provider * --cloud-volume-plugin * --configure-cloud-routes Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade |
|
@soltysh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/58b3c3d0-1450-11ef-84b1-3fe441cb6228-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade |
|
@soltysh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/727d3cb0-1464-11ef-9e43-1087e71d9b89-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.17.0-202405172342.p0.g0bc5f82.assembly.stream.el9 for distgit ose-cluster-kube-controller-manager-operator. |
|
/lgtm |
JoelSpeed
changed the title
Replaces #799
/assign @JoelSpeed @nrb @ingvagabund