Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go.mod #179

Merged
merged 8 commits into from Oct 10, 2019
Merged

Switch to go.mod #179

merged 8 commits into from Oct 10, 2019

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Oct 7, 2019

/assign @tnozicka
since you asked for it 馃槈
@damemi @ingvagabund fyi

Needs openshift/release#5312 to merge

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2019
@tnozicka
Copy link
Contributor

/refresh

@tnozicka
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Oct 10, 2019

/retest

@soltysh
Copy link
Member Author

soltysh commented Oct 10, 2019

/refresh

@soltysh
Copy link
Member Author

soltysh commented Oct 10, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2019

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify-deps 1b02c36 link /test verify-deps

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member Author

soltysh commented Oct 10, 2019

/override ci/prow/verify-deps

@openshift-ci-robot
Copy link

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member Author

soltysh commented Oct 10, 2019

Verify-deps was removed in openshift/release#5312

@openshift-merge-robot openshift-merge-robot merged commit 6fe7d42 into openshift:master Oct 10, 2019
@soltysh soltysh deleted the gomod branch October 11, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants