Bug 1834852: Add make target to run operator with telepresence #241
Conversation
marun
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
marun
force-pushed
the
telepresence
branch
2 times, most recently
from
beb373c
to
7fbe547
Compare
openshift-ci-robot
added
the
needs-rebase
marun
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@marun: This pull request references Bugzilla bug 1834852, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@marun: This pull request references Bugzilla bug 1834852, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
needs-rebase
|
@damemi @ingvagabund Is there something I'm missing in this PR that would be breaking |
| # Configure the 'telepresence' target | ||
| # See vendor/github.com/openshift/build-machinery-go/scripts/run-telepresence.sh for usage and configuration details | ||
| export TP_DEPLOYMENT_YAML ?=./manifests/0000_25_kube-scheduler-operator_06_deployment.yaml | ||
| export TP_CMD_PATH ?=./cmd/cluster-kube-scheduler-operator |
There was a problem hiding this comment.
Since you don't use $(call telepresence ...), will both variables have any effect?
There was a problem hiding this comment.
Thank you for your review! The make target added by line 10 will be configured by these values. I've tested it to work on this and other PRs adding the telepresence target. Feel free to give it a try! :)
|
@marun I don't see how your changes might be related to /retest |
|
Changes are scoped to the Makefile only. No customer impact. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@marun: Some pull requests linked via external trackers have merged: openshift/cluster-authentication-operator#276, openshift/cluster-authentication-operator#284. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Once telepresence has been installed (see the run-telepresence.sh script for instructions),
make telepresencewill replace the operator's pod with a local process that has access to the same environment as the pod. This can speed up development since iteration doesn't rely on image build/push/pull cycle. See https://telepresence.io for more details.