Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to delay version update until operand updated #272

Merged
merged 1 commit into from Aug 18, 2020
Merged

bump to delay version update until operand updated #272

merged 1 commit into from Aug 18, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 13, 2020

@deads2k deads2k mentioned this pull request Aug 13, 2020
Merged
4 tasks
@deads2k
Copy link
Contributor Author

deads2k commented Aug 17, 2020

/test all

@deads2k deads2k changed the title fakebump to delay version update until operand updated bump to delay version update until operand updated Aug 17, 2020
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 17, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Aug 17, 2020

proof was green, this is updating library-go to match and it will clean up our upgrade logging and events

sanchezl
sanchezl approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Aug 17, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0b5bbf into openshift:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezl sanchezl sanchezl approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@sanchezl sanchezl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @openshift-ci-robot @openshift-bot @sanchezl @openshift-merge-robot