static pod operator should not update versions until the image is new #865
Conversation
openshift-ci-robot
added
the
approved
| ) | ||
| c.versionRecorder.SetVersion( | ||
| "operator", | ||
| status.VersionForOperatorFromEnv(), |
There was a problem hiding this comment.
Is this setting the operator version for the operator as a whole, or just for this one static pod controller (with the operator's operator version leveling after all its sub-controllers have leveled)?
There was a problem hiding this comment.
Is this setting the
operatorversion for the operator as a whole, or just for this one static pod controller (with the operator'soperatorversion leveling after all its sub-controllers have leveled)?
it's voting. anything needing a different version sets it separately. But static pod operators don't get choices, it changes when their static pods are up to date.
There was a problem hiding this comment.
...it's voting. anything needing a different version sets it separately...
Is there aggregation logic that tallies votes somewhere, similar to what UnionClusterCondition does for conditions? Grepping for "operator" is not turning up an aggregator for me...
There was a problem hiding this comment.
For what it's worth, I'd expect each controller to set an operandName, as you have a bit further up here. And then operator-level logic that looks at all the controllers and bumps operator when they all match their target operand version.
|
|
||
| default: // we have one image | ||
| // if have a consistent image and if that image the same as the current operand image, then we can update the version to reflect our new version | ||
| if images.List()[0] == status.ImageForOperandFromEnv() { |
There was a problem hiding this comment.
nit:
case images.List()[0] == status.ImageForOperandFromEnv():
...
default:
// we have one image, but it is NOT the current operand image so we don't update the version
}would unroll one level of nesting, right?
There was a problem hiding this comment.
I think the intent it clearer as is.
|
|
||
| default: // we have one image | ||
| // if have a consistent image and if that image the same as the current operand image, then we can update the version to reflect our new version | ||
| if images.List()[0] == status.ImageForOperandFromEnv() { |
There was a problem hiding this comment.
I think the intent it clearer as is.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes a bug, but I don't know which one.
Proof PRs are needed for the big static pod operator. Will link shortly.