Policy configmap working with kube-scheduler #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
| @@ -146,6 +148,7 @@ func RunOperator(ctx *controllercmd.ControllerContext) error { | |||
| kubeInformersClusterScoped.Start(ctx.Done()) | |||
| kubeInformersNamespace.Start(ctx.Done()) | |||
| kubeInformersForNamespaces.Start(ctx.Done()) | |||
| configInformers.Start(ctx.Done()) | |||
There was a problem hiding this comment.
This was something I missed last time.
ravisantoshgudimetla
force-pushed
the
test-policyconfigmap
branch
from
91fbc4e
to
02643fb
Compare
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| kind: Role | ||
| name: system:openshift:sa-listing-configmaps | ||
| subjects: | ||
| - kind: ServiceAccount |
There was a problem hiding this comment.
The generated data is wrong. I missed two commits which is causing this PR to fail.
Note to myself: Add verify-generated bindata..
There was a problem hiding this comment.
/cc @sjenning
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
system:kube-scheduleruser to access configmaps inopenshift-kube-schedulernamespace. This was not an issue before Rotate kubeconfig #62 merged but after that we have to add following roles/rolebindings./cc @sjenning
We are able to pick up configmap changes now.
I0321 23:06:23.187561 1 factory.go:1118] Creating scheduler from configuration: {{ } [{PodFitsHostPorts <nil>} {PodFitsResources <nil>} {NoDiskConflict <nil>} {NoVolumeZoneConflict <nil>} {MatchNodeSelector <nil>} {HostName <nil>}] [{LeastRequestedPriority 1 <nil>} {BalancedResourceAllocation 1 <nil>} {ServiceSpreadingPriority 1 <nil>} {EqualPriority 1 <nil>}] [] 0 false}We can see above line in kube-scheduler logs.