Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindata #79

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Update bindata #79

merged 1 commit into from
Mar 28, 2019

Conversation

ravisantoshgudimetla
Copy link
Contributor

I missed two commits while pushing changes related to #76 which is causing to generate a different rolebindings.

/cc @sjenning.

will add an e2e related to this subsequent PRs.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2019
@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Mar 26, 2019
Merged
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

4 similar comments
@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

@sjenning
Copy link
Contributor

/retest
verify should work now openshift/release#3249

@ravisantoshgudimetla
Copy link
Contributor Author

/test e2e-aws

1 similar comment
@ravisantoshgudimetla
Copy link
Contributor Author

/test e2e-aws

@ravisantoshgudimetla
Copy link
Contributor Author

/test verify

@sttts
Copy link
Contributor

sttts commented Mar 27, 2019

/retest

@sttts
Copy link
Contributor

sttts commented Mar 27, 2019

fyi, with another library-go bump bindata will always be checked in CI.

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

2 similar comments
@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit c0eac64 into openshift:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@sttts sttts Awaiting requested review from sttts

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ravisantoshgudimetla @sjenning @openshift-ci-robot @sttts @openshift-merge-robot