-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-2455: fix infra logs showing in app log group #1431
LOG-2455: fix infra logs showing in app log group #1431
Conversation
I wanted to comment, that I wasn't sure of the impact of utilizing a long regex like this. Let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/approve
Seems like we could write a functional test to expose this issue and then verify it does not get re-introduced
34f76c6
to
a4bee90
Compare
a4bee90
to
83ba72e
Compare
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cahartma: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/cherrypick release-5.4 |
@jcantrill: #1431 failed to apply on top of branch "release-5.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
fixes issue where infra container logs were being captured by the application log group
/assign @vimalk78 @jcantrill
Links