Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-2455: fix infra logs showing in app log group #1431

Conversation

cahartma
Copy link
Contributor

Description

fixes issue where infra container logs were being captured by the application log group

/assign @vimalk78 @jcantrill

Links

@cahartma
Copy link
Contributor Author

I wanted to comment, that I wasn't sure of the impact of utilizing a long regex like this. Let me know.

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/approve

Seems like we could write a functional test to expose this issue and then verify it does not get re-introduced

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2022
@cahartma cahartma force-pushed the LOG-2455-infra-logs-in-app-group-name branch from 34f76c6 to a4bee90 Compare April 29, 2022 19:04
@cahartma cahartma changed the title use regex for filtering the application group_name LOG-2455: fix infra logs showing in app log group Apr 30, 2022
test/framework/functional/write.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2022
@cahartma cahartma force-pushed the LOG-2455-infra-logs-in-app-group-name branch from a4bee90 to 83ba72e Compare May 2, 2022 18:36
@jcantrill
Copy link
Contributor

/hold cancel
/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit b26497c into openshift:master May 3, 2022
@jcantrill
Copy link
Contributor

/cherrypick release-5.4

@openshift-cherrypick-robot

@jcantrill: #1431 failed to apply on top of branch "release-5.4":

Applying: LOG-2455 fix infra logs showing in app log group
Using index info to reconstruct a base tree...
M	internal/generator/fluentd/output/cloudwatch/output_cloudwatch_test.go
M	test/framework/functional/write.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/functional/write.go
Auto-merging internal/generator/fluentd/output/cloudwatch/output_cloudwatch_test.go
CONFLICT (content): Merge conflict in internal/generator/fluentd/output/cloudwatch/output_cloudwatch_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 LOG-2455 fix infra logs showing in app log group
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants