Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-3613: Bump k8s client go version to 1.24.9 #1885

Merged
merged 1 commit into from Feb 27, 2023
Merged

LOG-3613: Bump k8s client go version to 1.24.9 #1885

merged 1 commit into from Feb 27, 2023

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Feb 22, 2023 •
edited

Description

This PR:

  • bump k8s client-go version to 1.24.9 from 1.23.5
  • bump prometheus-operator to v0.55.1 from v0.38.1
  • remove replace k8s.io/client-go => k8s.io/client-go v0.23.5 // Required by prometheus-operator from go.mod
  • kubeclock.Clock is deprecated: Use k8s.io/utils/clock.WithTickerAndDelayedExecution instead

/cc
/assign @jcantrill

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-3613 which is a valid jira issue.

In response to this:

Description

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vparfonov
Copy link
Contributor Author

/test all

@vparfonov
Copy link
Contributor Author

/test lint

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-3613 which is a valid jira issue.

In response to this:

Description

This PR:

  • bump k8s client-go version to 1.24.9 from 1.23.5
  • bump prometheus-operator to v0.55.1 from v0.38.1
  • remove replace k8s.io/client-go => k8s.io/client-go v0.23.5 // Required by prometheus-operator from go.mod
  • kubeclock.Clock is deprecated: Use k8s.io/utils/clock.WithTickerAndDelayedExecution instead

/cc
/assign @jcantrill

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov vparfonov marked this pull request as ready for review February 23, 2023 12:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@vimalk78
Copy link
Contributor

Switch to the "rich diff" to see file diff, and it shows a Critical Severity issue in one of the dependencies in go.mod
https://github.com/openshift/cluster-logging-operator/pull/1885/files?diff=unified&w=0&short_path=33ef32b#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

@jcantrill
Copy link
Contributor

Switch to the "rich diff" to see file diff, and it shows a Critical Severity issue in one of the dependencies in go.mod https://github.com/openshift/cluster-logging-operator/pull/1885/files?diff=unified&w=0&short_path=33ef32b#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

@vparfonov we might as well patch these critical libs with this change

@vparfonov
LOG-3613: Bump k8s client go version to 1.24.9
63c4940 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov
Copy link
Contributor Author

@vimalk78 @jcantrill fixed your comments

@vparfonov
Copy link
Contributor Author

/test functional-target

@vparfonov
Copy link
Contributor Author

/test e2e-ocp-target-minus-one

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target 63c4940 link false /test functional-target

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vparfonov vparfonov requested review from vimalk78 and removed request for alanconway and syedriko February 26, 2023 17:40
@vparfonov vparfonov mentioned this pull request Feb 27, 2023
Merged
@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@jcantrill
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0034fdb into openshift:master Feb 27, 2023
@vparfonov vparfonov deleted the log3613 branch February 27, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vparfonov @openshift-ci-robot @vimalk78 @jcantrill @openshift-merge-robot