Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-3712: Upgrade Operator SDK to 1.24 #1886

Merged
merged 1 commit into from Mar 8, 2023
Merged

LOG-3712: Upgrade Operator SDK to 1.24 #1886

merged 1 commit into from Mar 8, 2023

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Feb 23, 2023 •
edited

Description

/cc
/assign

/cherry-pick

Links

@vparfonov
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@vparfonov vparfonov changed the title Upgrade Operator SDK to 1.24 WIP:Upgrade Operator SDK to 1.24 Feb 23, 2023
@vparfonov vparfonov marked this pull request as ready for review February 23, 2023 21:04
@vparfonov
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@vparfonov vparfonov changed the title WIP:Upgrade Operator SDK to 1.24 Upgrade Operator SDK to 1.24 Feb 23, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@vparfonov vparfonov changed the title Upgrade Operator SDK to 1.24 WIP: Upgrade Operator SDK to 1.24 Feb 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023
@vparfonov vparfonov changed the title WIP: Upgrade Operator SDK to 1.24 WIP: LOG-3712: Upgrade Operator SDK to 1.24 Feb 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-3712 which is a valid jira issue.

In response to this:

Description

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov vparfonov force-pushed the opsdk-1.24 branch 3 times, most recently from 1fd865d to 0e56282 Compare February 27, 2023 18:39
@vparfonov vparfonov changed the title WIP: LOG-3712: Upgrade Operator SDK to 1.24 LOG-3712: Upgrade Operator SDK to 1.24 Feb 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023
@vparfonov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023
@vparfonov
LOG-3712: Upgrade Operator SDK to 1.24
0e56282 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@jcantrill
Copy link
Contributor

/approve
/hold cancel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
jcantrill
jcantrill reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8a6ce89 and 2 for PR HEAD 0e56282 in total

@jcantrill
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ff88cae and 1 for PR HEAD 0e56282 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5d02430 and 0 for PR HEAD 0e56282 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target 0e56282 link false /test functional-target

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1773759 into openshift:master Mar 8, 2023
@vparfonov vparfonov deleted the opsdk-1.24 branch March 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@alanconway alanconway Awaiting requested review from alanconway

@cahartma cahartma Awaiting requested review from cahartma

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vparfonov @openshift-ci-robot @jcantrill @openshift-merge-robot