-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt a fix to functional test flake #794
Attempt a fix to functional test flake #794
Conversation
5326d04
to
47b404a
Compare
/retest |
1 similar comment
/retest |
47b404a
to
754790c
Compare
- wait for fluentd service to be ready before curl-ing it - fixed "odd number of arguments" to structured logging in oc/runner
754790c
to
d7c5aaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ests Attempt a fix to functional test flake
Attempt a fix to functional test flake
Description
The metrics functional test fails because
curl
to the metrics endpoint fails. So wait for the service endpoint to have IPs before attempting to curl it./cc @jcantrill
/assign @alanconway