Attempt a fix to functional test flake #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimalk78
force-pushed
the
minor-fix-functional-tests
branch
2 times, most recently
from
5326d04
to
47b404a
Compare
|
/retest |
1 similar comment
|
/retest |
vimalk78
force-pushed
the
minor-fix-functional-tests
branch
from
47b404a
to
754790c
Compare
jcantrill
reviewed
Nov 17, 2020
- wait for fluentd service to be ready before curl-ing it - fixed "odd number of arguments" to structured logging in oc/runner
vimalk78
force-pushed
the
minor-fix-functional-tests
branch
from
754790c
to
d7c5aaa
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
pmoogi-redhat
pushed a commit
to pmoogi-redhat/cluster-logging-operator
that referenced
this pull request
Apr 26, 2022
…ests Attempt a fix to functional test flake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt a fix to functional test flake
Description
The metrics functional test fails because
curlto the metrics endpoint fails. So wait for the service endpoint to have IPs before attempting to curl it./cc @jcantrill
/assign @alanconway