Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28230: add FallbackToLogsOnError for easier debugging #227

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 25, 2024

All openshift operators must include FallbackToLogsOnError to ease debugging.

@deads2k deads2k changed the title add FallbackToLogsOnError for easier debugging OCPBUGS-28230: add FallbackToLogsOnError for easier debugging Jan 25, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 25, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 25, 2024
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1df5c45 and 2 for PR HEAD b0be47f in total

@deads2k
Copy link
Contributor Author

deads2k commented Jan 27, 2024

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Jan 27, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-capi-techpreview b0be47f link true /test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-capi-techpreview

I'm happy that the failures here are unrelated to this PR

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@JoelSpeed: Cannot get commit checkruns for PR #227 in openshift/cluster-machine-approver

In response to this:

/override ci/prow/e2e-aws-capi-techpreview

I'm happy that the failures here are unrelated to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-capi-techpreview

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Jan 29, 2024

/override ci/prow/e2e-aws-capi-techpreview

@JoelSpeed JoelSpeed merged commit 2d68698 into openshift:master Jan 29, 2024
7 of 9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-machine-approver-container-v4.16.0-202401291644.p0.g2d68698.assembly.stream for distgit ose-cluster-machine-approver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants