Bug 1779107: Fall back to machine-api check if certificate check fails #57
Conversation
This falls back to the original machine-api based checks for serving certificate renewals if the checks based on retrieving the current serving certificate fail. This is needed in cases where network interfaces are added to a machine after its initial creation, because the SAN list in the new CSR will contain new addresses and no longer match the current certificate exactly. This requires the machine-controller to track all addresses on a machine, which was recently fixed for AWS: openshift/cluster-api-provider-aws#277
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@bison: This pull request references Bugzilla bug 1779107, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
|
/cherry-pick release-4.3 |
|
@bison: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@bison: new pull request created: #58 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This falls back to the original machine-api based checks for serving
certificate renewals if the checks based on retrieving the current
serving certificate fail. This is needed in cases where network
interfaces are added to a machine after its initial creation, because
the SAN list in the new CSR will contain new addresses and no longer
match the current certificate exactly.
This requires the machine-controller to track all addresses on a
machine, which was recently fixed for AWS:
openshift/cluster-api-provider-aws#277