Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1779107: Fall back to machine-api check if certificate check fails #57

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Bug 1779107: Fall back to machine-api check if certificate check fails #57

merged 1 commit into from
Dec 6, 2019

Commits on Dec 6, 2019

  1. Fall back to machine-api check if certificate check fails 

    This falls back to the original machine-api based checks for serving
certificate renewals if the checks based on retrieving the current
serving certificate fail.  This is needed in cases where network
interfaces are added to a machine after its initial creation, because
the SAN list in the new CSR will contain new addresses and no longer
match the current certificate exactly.

This requires the machine-controller to track all addresses on a
machine, which was recently fixed for AWS:

  openshift/cluster-api-provider-aws#277
    @bison
    bison committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    ca3eb90 View commit details
    Browse the repository at this point in the history