Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release checklist template #1011

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Update release checklist template #1011

merged 1 commit into from
Dec 16, 2020

Conversation

dgrisonnet
Copy link
Member

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@dgrisonnet dgrisonnet changed the title WIP: Update release checklist template Update release checklist template Dec 14, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2020
@dgrisonnet
Copy link
Member Author

@openshift/openshift-team-monitoring PTAL

@dgrisonnet
Copy link
Member Author

/retest

@simonpasquier
Copy link
Contributor

we need also to bump versions in hack/tools/go.mod (especially prometheus version should be synced with the main go.mod). Noticed while looking at #1020 which fails because it uses the group aggregator that isn't supported by the promtool version pulled from hack/tools/go.mod.

@dgrisonnet
Update release checklist template
1814805 
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
simonpasquier
simonpasquier reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet
Copy link
Member Author

/retest

@s-urbaniak s-urbaniak added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 201f939 into openshift:master Dec 16, 2020
@dgrisonnet dgrisonnet deleted the update-release-checklist branch December 16, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgrisonnet @simonpasquier @openshift-ci-robot @s-urbaniak @openshift-merge-robot