Bug 1916056: manifest allowlist: add ACM metric #1035
Conversation
Add Red Hat Advanced Cluster Management for Kubernetes metric visual_web_terminal_sessions_total to the manifest allowlist
|
Hi @mark-nc. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
Documentation/data-collection.md
Outdated
| @@ -245,6 +245,9 @@ data: | |||
| # (@openshift/storage, OpenShift Storage team) Persistent Volume usage metrics: this is the number of volumes per plugin | |||
| # and per volume type (filesystem/block) | |||
| - '{__name__="cluster:kube_persistentvolume_plugin_type_counts:sum"}' | |||
| # (Advanced Cluster Management) visual_web_terminal_sessions_total is the count of Visual Web Terminal sessions created | |||
There was a problem hiding this comment.
Do you not have a team under openshift org we can ping in case we need to change/remove anything?
There was a problem hiding this comment.
I will have to check. I think all of our Github teams (if that is what you mean) are under our open-cluster-management org.
There was a problem hiding this comment.
Yes we prefer a GitHub team if possible.
There was a problem hiding this comment.
OK, let me get the right one and I will update comment in the yaml with that.
| @@ -245,6 +245,9 @@ data: | |||
| # (@openshift/storage, OpenShift Storage team) Persistent Volume usage metrics: this is the number of volumes per plugin | |||
| # and per volume type (filesystem/block) | |||
| - '{__name__="cluster:kube_persistentvolume_plugin_type_counts:sum"}' | |||
| # (Advanced Cluster Management) visual_web_terminal_sessions_total is the count of Visual Web Terminal sessions created | |||
| # on the hub cluster. | |||
| - '{__name__="visual_web_terminal_sessions_total"}' | |||
There was a problem hiding this comment.
What is the cardinality for this in total for this metric, I could not find the metric visual_web_terminal_sessions_total via search, do you mind sharing the repo where its created?
cc @smarterclayton I was told they have your 👍 already
There was a problem hiding this comment.
This metric has no labels so it will be a singleton per hub OCP cluster where ACM is installed. So from a telemetry standpoint, there will be one occurrence of this counter for every ACM hub cluster participating in telemetry.
The metric is created in this repo here https://github.com/open-cluster-management/kui-web-terminal/blob/master/proxy/app/lib/metricsUtils.js
mark-nc
changed the title
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@mark-nc: This pull request references Bugzilla bug 1916056, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-low
|
@simonpasquier: This pull request references Bugzilla bug 1916056, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
add the appropriate github user group contact to the comment in the yaml above the entry for visual_web_terminal_sessions_total metric
updating the Documentation/data-collection.md doc as this step was not included in the last commit
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mark-nc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
@mark-nc: All pull requests linked via external trackers have merged: Bugzilla bug 1916056 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add Red Hat Advanced Cluster Management for Kubernetes metric visual_web_terminal_sessions_total to the manifest allowlist