Bug 1929277: Adjust priority class of core platform prometheus #1055
Conversation
lilic
commented
Feb 16, 2021
lilic
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
openshift-ci-robot
added
the
approved
| openshiftSystemPriorityClass.Value < systemNodePriorityClass.Value || | ||
| userPriorityClass.Value < openshiftSystemPriorityClass.Value { | ||
| t.Fatalf("openshift-system-critical was wrong priority class: %d", openshiftSystemPriorityClass.Value) | ||
| } |
|
Aimed towards master, but I guess 4.7 is better as its urgent? |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
let's give @smarterclayton and @rphillips the final call (to unhold) |
|
/cherry-pick release-4.7 |
|
@s-urbaniak: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thanks, that is even better Serg! 🤞 |
|
BZ for this PR https://bugzilla.redhat.com/show_bug.cgi?id=1913532 |
lilic
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@lilic: This pull request references Bugzilla bug 1913532, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@rphillips: This pull request references Bugzilla bug 1913532, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest from what I can tell its non monitoring issue. |
|
/retest
|
openshift-ci-robot
added
bugzilla/invalid-bug
|
@lilic: This pull request references Bugzilla bug 1913532, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel not seeing anything in the slack discussions that makes me think @rphillips or @smarterclayton disagree w/ this. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| value: 1000001000 |
There was a problem hiding this comment.
The PriorityClass "openshift-system-critical" is invalid: value: Forbidden: maximum allowed value of a user defined priority is 1000000000
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
lilic
force-pushed
the
adjust-prom-class
branch
from
8d9ece2
to
bfa9dce
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold this needs to be redone based on #1060 |
openshift-ci-robot
added
the
do-not-merge/hold
|
@lilic: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@lilic: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@lilic: This pull request references Bugzilla bug 1929277. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
superseded by #1067 |
