Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kube-state-metrics to v2.0.0-rc.1 #1093

Closed
wants to merge 5 commits into from
Closed

Bump kube-state-metrics to v2.0.0-rc.1 #1093

wants to merge 5 commits into from

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Mar 29, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 29, 2021
@lilic
Copy link
Contributor Author

lilic commented Mar 29, 2021

Bump PR -> openshift/kube-state-metrics#47

lilic
lilic commented Mar 29, 2021
View reviewed changes
assets/alertmanager/pod-disruption-budget.yaml
@@ -0,0 +1,20 @@
apiVersion: policy/v1beta1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we want, this was generated by bumping kube-prom I believe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1933847

lilic
lilic commented Mar 29, 2021
View reviewed changes
assets/prometheus-k8s/pod-disruption-budget.yaml
@@ -0,0 +1,20 @@
apiVersion: policy/v1beta1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for this file.

@lilic lilic changed the title WIP: Bump kube-state-metrics to v2.0.0-rc.1 Bump kube-state-metrics to v2.0.0-rc.1 Mar 29, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2021
@lilic
Copy link
Contributor Author

lilic commented Mar 29, 2021

Ready for review, but not for merge, hold still applies.

@lilic
Copy link
Contributor Author

lilic commented Mar 30, 2021

Waiting for openshift/kube-state-metrics#47

@simonpasquier
Copy link
Contributor

/lgtm

Though it seems backwards, we need this PR to be merged before the bump to kube-state-metrics v2 (see openshift/kube-state-metrics#47 (comment)). Because of metric changes, A few rules using kube-state-metrics wouldn't provide results once this PR get merged but the plan is to merge openshift/kube-state-metrics#47 right after so the discrepancy shouldn't be noticeable.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@lilic lilic mentioned this pull request Mar 30, 2021
Merged
@lilic
Copy link
Contributor Author

lilic commented Mar 30, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
simonpasquier
simonpasquier reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lilic,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Contributor Author

lilic commented Mar 30, 2021

/hold

Putting on hold for now, until tests are green, so this can be merged in coordination with openshift/kube-state-metrics#47.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@simonpasquier
Copy link
Contributor

/test e2e-agnostic

@simonpasquier
Copy link
Contributor

The upgrade job fails because the service account don't have permissions to list the ingress resources. I'll investigate later.

E0330 15:28:28.661842       1 reflector.go:178] k8s.io/kube-state-metrics/internal/store/builder.go:346: Failed to list *v1beta1.Ingress: ingresses.extensions is forbidden: User "system:serviceaccount:openshift-monitoring:kube-state-metrics" cannot list resource "ingresses" in API group "extensions" at the cluster scope
E0330 15:28:29.692772       1 reflector.go:178] k8s.io/kube-state-metrics/internal/store/builder.go:346: Failed to list *v1beta1.Ingress: ingresses.extensions is forbidden: User "system:serviceaccount:openshift-monitoring:kube-state-metrics" cannot list resource "ingresses" in API group "extensions" at the cluster scope
E0330 15:28:31.627119       1 reflector.go:178] k8s.io/kube-state-metrics/internal/store/builder.go:346: Failed to list *v1beta1.Ingress: ingresses.extensions is forbidden: User "system:serviceaccount:openshift-monitoring:kube-state-metrics" cannot list resource "ingresses" in API group "extensions" at the cluster scope

@simonpasquier simonpasquier mentioned this pull request Mar 31, 2021
Merged
2 tasks
@simonpasquier
Copy link
Contributor

Trying to fix the CI failures in #1099

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2021

@lilic: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade f77b784 link /test e2e-agnostic-upgrade
ci/prow/e2e-agnostic f77b784 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/close
superseded by #1099

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: Closed this PR.

In response to this:

/close
superseded by #1099

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier simonpasquier mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@jan--f jan--f Awaiting requested review from jan--f

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilic @simonpasquier @openshift-ci-robot