Bug 1955457: drop container_memory_failures_total metric #1131
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@simonpasquier: This pull request references Bugzilla bug 1951052, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@simonpasquier since we are removing metrics from containers, would it be meaningful to ask for reviews from the node team to better understand why these metrics exist and assess whether any alerts or dashboards are missing? Moreover since we plan to give them ownership of the kubelet monitoring, it might be worth putting them in the loop. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
For reference, this metric tracks container page faults. We can remove it for now. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/test e2e-agnostic |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-agnostic |
|
/retitle Bug 1955457: drop container_memory_failures_total metric |
openshift-ci-robot
changed the title
|
@simonpasquier: This pull request references Bugzilla bug 1955457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-agnostic |
|
@simonpasquier: All pull requests linked via external trackers have merged: Bugzilla bug 1955457 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The
container_memory_failures_totalmetric isn't used anywhere and it generates at least 4 series per container.