Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec #1289

philipgough · 2021-07-19T10:58:22Z

This is cherry pick of #1277 which backports to 4.8.z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

The exec probe is timing out intermittently. This coud be caused in part by the timing on the probe not being sufficient, or there may be an underlying issue with the (exec, cri-o) combo. This change takes the config for httpGet probes from upstream thanos and proxies to thanos via the oauth-gateway where we bypass the health check endpoints. The HTTP probe cannot directly ping thanos since it listens on localhost and is unreachable from kubelet. This is by design.

openshift-ci · 2021-07-19T10:58:23Z

@philipgough: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

jsonnet: thanosquery: Use HTTP probes as opposed to exec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-19T10:59:15Z

@philipgough: This pull request references Bugzilla bug 1982778, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

philipgough · 2021-07-19T10:59:31Z

/hold for 4.8.z release

philipgough · 2021-07-19T11:43:16Z

/retest

philipgough · 2021-07-19T13:45:47Z

/test e2e-agnostic-operator

simonpasquier

/lgtm

prashbnair · 2021-07-21T05:03:34Z

/lgtm

openshift-ci · 2021-07-21T05:03:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PhilipGough, prashbnair, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

simonpasquier · 2021-07-23T10:22:59Z

/bugzilla refresh

openshift-ci · 2021-07-23T10:23:06Z

@simonpasquier: This pull request references Bugzilla bug 1982778, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1980888 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1980888 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2021-07-23T10:23:36Z

/hold cancel

openshift-bot · 2021-07-23T15:32:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-23T16:11:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-23T16:37:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-23T22:38:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-04T06:49:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-04T08:57:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-04T11:57:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-04T12:57:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ecordell · 2021-08-04T19:03:18Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

Score: 0.20
Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

openshift-bot · 2021-08-05T07:09:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-05T07:22:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-05T07:36:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-05T08:02:01Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

paulfantom · 2021-08-05T08:25:48Z

/skip

ecordell · 2021-08-05T18:54:45Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

Score: 0.20
Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

ecordell · 2021-08-05T18:55:37Z

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

openshift-bot · 2021-08-05T19:56:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ecordell · 2021-08-05T22:40:31Z

/retest

openshift-bot · 2021-08-05T23:05:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-06T12:55:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-06T14:52:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-06T16:35:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-07T16:55:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-07T20:59:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-08T01:59:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-08T04:11:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-08T04:23:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-08T05:26:32Z

@philipgough: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-single-node	`7b50ff1`	link	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-08T05:35:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-08T05:47:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-08T06:56:38Z

@philipgough: All pull requests linked via external trackers have merged:

openshift/cluster-monitoring-operator#1289

Bugzilla bug 1982778 has been moved to the MODIFIED state.

In response to this:

Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from dgrisonnet and simonpasquier July 19, 2021 10:58

philipgough changed the title ~~jsonnet: thanosquery: Use HTTP probes as opposed to exec~~ Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec Jul 19, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021

simonpasquier reviewed Jul 20, 2021

View reviewed changes

openshift-ci bot assigned simonpasquier Jul 20, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2021

openshift-ci bot assigned prashbnair Jul 21, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 23, 2021

openshift-ci bot requested a review from juzhao July 23, 2021 10:23

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021

ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021

openshift-ci bot merged commit e3f9fd7 into openshift:release-4.8 Aug 8, 2021

philipgough deleted the bz-1982778 branch August 9, 2021 13:52

Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec #1289

Bug 1982778: jsonnet: thanosquery: Use HTTP probes as opposed to exec #1289

Conversation

philipgough commented Jul 19, 2021

openshift-ci bot commented Jul 19, 2021

openshift-ci bot commented Jul 19, 2021

philipgough commented Jul 19, 2021

philipgough commented Jul 19, 2021

philipgough commented Jul 19, 2021

simonpasquier left a comment

Choose a reason for hiding this comment

prashbnair commented Jul 21, 2021

openshift-ci bot commented Jul 21, 2021

simonpasquier commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

simonpasquier commented Jul 23, 2021

openshift-bot commented Jul 23, 2021

openshift-bot commented Jul 23, 2021

openshift-bot commented Jul 23, 2021

openshift-bot commented Jul 23, 2021

openshift-bot commented Aug 4, 2021

openshift-bot commented Aug 4, 2021

openshift-bot commented Aug 4, 2021

openshift-bot commented Aug 4, 2021

ecordell commented Aug 4, 2021

openshift-bot commented Aug 5, 2021

openshift-bot commented Aug 5, 2021

openshift-bot commented Aug 5, 2021

openshift-bot commented Aug 5, 2021

paulfantom commented Aug 5, 2021

ecordell commented Aug 5, 2021

ecordell commented Aug 5, 2021

openshift-bot commented Aug 5, 2021

ecordell commented Aug 5, 2021

openshift-bot commented Aug 5, 2021

openshift-bot commented Aug 6, 2021

openshift-bot commented Aug 6, 2021

openshift-bot commented Aug 6, 2021

openshift-bot commented Aug 7, 2021

openshift-bot commented Aug 7, 2021

openshift-bot commented Aug 8, 2021

openshift-bot commented Aug 8, 2021

openshift-bot commented Aug 8, 2021

openshift-ci bot commented Aug 8, 2021 • edited

openshift-bot commented Aug 8, 2021

openshift-bot commented Aug 8, 2021

openshift-ci bot commented Aug 8, 2021

openshift-ci bot commented Aug 8, 2021 •

edited