-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/local-cmo.sh: fix CVO override #1498
hack/local-cmo.sh: fix CVO override #1498
Conversation
Since [1] got merged, CVO checks that the manifest's group matches with the override definition hence the `/v1` needs to be removed. [1] openshift/cluster-version-operator#689 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Just need to verify locally that it's indeed fixing the issue. |
/label qe-approved No user facing change, this script is used by monitoring developers to test changes locally. |
/hold cancel |
tested successfully |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/skip |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/test e2e-agnostic-upgrade |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Since [1] got merged, CVO checks that the manifest's group matches with
the override definition hence the
/v1
needs to be removed.[1] openshift/cluster-version-operator#689