Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ovnkube_master_egress_routing_via_host via telemetry #1635

Merged
merged 1 commit into from
May 11, 2022

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Apr 12, 2022

OVN-K openshift clusters have a metric called ovnkube_master_egress_routing_via_host in openshift-ovn-kubernetes namespace which conveys the gateway mode used by the users (values: 0/1/2). Cardinality is bounded, no labels for the metric so single time series. See https://docs.google.com/document/d/1pzabXpCIMo5e941g_F7vMOzVj8zy2xy4kFxeyIbRhPQ/edit for details.

cc @martinkennelly Metrics Area
cc @trozet SDN Team Lead

Note to reviewers: This is my first PR against CMO; so forgive blunders.

@npinaeva
Copy link
Member

from the networking perspective
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@martinkennelly
Copy link

/lgtm

@tssurya
Copy link
Contributor Author

tssurya commented Apr 19, 2022

/test e2e-aws-single-node

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@simonpasquier
Copy link
Contributor

you need to run make generate locally and commit the modified files too :)

@tssurya
Copy link
Contributor Author

tssurya commented May 9, 2022

you need to run make generate locally and commit the modified files too :)

oops my bad :D ack let me do this, thanks Simon!

@tssurya tssurya requested review from simonpasquier and removed request for bison May 10, 2022 13:55
@simonpasquier
Copy link
Contributor

/lgtm
/test e2e-agnostic-upgrade

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkennelly, npinaeva, simonpasquier, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@tssurya
Copy link
Contributor Author

tssurya commented May 10, 2022

/test e2e-agnostic-upgrade

@tssurya
Copy link
Contributor Author

tssurya commented May 10, 2022

@simonpasquier : any idea how to get the required labels? Since this isn't a bug, I'd have to get the labels from each docs/px/qe teams? how does this work since generally those things come after the PR is merged...

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

@simonpasquier : any idea how to get the required labels? Since this isn't a bug, I'd have to get the labels from each docs/px/qe teams? how does this work since generally those things come after the PR is merged...

in this case, I can assign the labels myself.

/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants