-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ovnkube_master_egress_routing_via_host via telemetry #1635
Conversation
from the networking perspective |
/lgtm |
/test e2e-aws-single-node |
you need to run |
oops my bad :D ack let me do this, thanks Simon! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkennelly, npinaeva, simonpasquier, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-agnostic-upgrade |
@simonpasquier : any idea how to get the required labels? Since this isn't a bug, I'd have to get the labels from each docs/px/qe teams? how does this work since generally those things come after the PR is merged... |
@tssurya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
in this case, I can assign the labels myself. /label qe-approved |
OVN-K openshift clusters have a metric called
ovnkube_master_egress_routing_via_host
inopenshift-ovn-kubernetes
namespace which conveys the gateway mode used by the users (values: 0/1/2). Cardinality is bounded, no labels for the metric so single time series. See https://docs.google.com/document/d/1pzabXpCIMo5e941g_F7vMOzVj8zy2xy4kFxeyIbRhPQ/edit for details.cc @martinkennelly Metrics Area
cc @trozet SDN Team Lead
Note to reviewers: This is my first PR against CMO; so forgive blunders.