Bug 2083460: Set timeout across Grafana components

[arajkumar]

This commit sets timeout value across Grafana components
e.g. data source proxy and router. By default 120s is set as a
timeout and can be overridden using a jsonnet variable grafanaTimeout
during build time.

Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci]

@arajkumar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: increase grafana timeouts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@arajkumar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: increase grafana timeouts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@arajkumar: This pull request references Bugzilla bug 2070596, which is invalid:

• expected the bug to target the "4.10.z" release, but it targets "---" instead
• expected Bugzilla bug 2070596 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2070596: Set timeout across Grafana components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@arajkumar: This pull request references Bugzilla bug 2083460, which is invalid:

• expected dependent Bugzilla bug 2070596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (WONTFIX) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2083460: Set timeout across Grafana components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arajkumar]

/bugzilla refresh

[openshift-ci]

@arajkumar: This pull request references Bugzilla bug 2083460, which is invalid:

• expected dependent Bugzilla bug 2070596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (CANTFIX) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arajkumar]

/bugzilla refresh

[openshift-ci]

@arajkumar: An error was encountered querying GitHub for users with public email (juzhao@redhat.com) for bug 2083460 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arajkumar]

/bugzilla refresh

[openshift-ci]

@arajkumar: This pull request references Bugzilla bug 2083460, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.z) matches configured target release for branch (4.10.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2070596 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2070596 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
• bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jan--f]

Nicely done, thank you!
/lgtm
/label backport-risk-assessed

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[jan--f]

/hold
Until @juzhao had a chance to look at this.

[arajkumar]

ping @juzhao to validate the fix.

[juzhao]

@arajkumar just one question, I see the annotations haproxy.router.openshift.io/timeout: 120s in assets/grafana/route.yaml file, but not find in grafana route

# oc -n openshift-monitoring exec -c cluster-monitoring-operator cluster-monitoring-operator-7f99575896-whls2 -- cat assets/grafana/route.yaml
apiVersion: v1
kind: Route
metadata:
  annotation:
    haproxy.router.openshift.io/timeout: 120s
  name: grafana
  namespace: openshift-monitoring


# oc -n openshift-monitoring get route grafana -oyaml
apiVersion: route.openshift.io/v1
kind: Route
metadata:
  annotations:
    openshift.io/host.generated: "true"
  creationTimestamp: "2022-05-19T04:36:55Z"
  name: grafana

[juzhao]

tested with the PR, all grafana dashboards are loaded without timeout error
/label cherry-pick-approved

[juzhao]

/label qe-approved

[juzhao]

@jan--f we can remove the /hold label

[arajkumar]

@juzhao looks like a typo :'(

annotation should be replaced with annotations!

[arajkumar]

/skip

We also need #1671 as this PR updates Route annotation field.

[openshift-ci]

@arajkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	5c9dcae	link	false	/test e2e-aws-single-node
ci/prow/versions	5c9dcae	link	false	/test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[arajkumar]

/skip

[jan--f]

/unhold
/lgtm
Thanks everyone, once #1671 merges we'll get the backport lined up as well and everything should make it into the next 4.10 z-stream release.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [arajkumar,jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@arajkumar: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#1654

Bugzilla bug 2083460 has been moved to the MODIFIED state.

In response to this:

Bug 2083460: Set timeout across Grafana components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.