-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-4029: test: increase timeout when checking remote write metrics #1820
[release-4.12] OCPBUGS-4029: test: increase timeout when checking remote write metrics #1820
Conversation
The TestPrometheusRemoteWrite/assert_remote_write_cluster_id_relabel_config_works test often fails in the CI. Looking at a successful run [1], the test takes more than 2 minutes to run while the sub-test checking the presence of the cluster_id label only retries for 2 minutes. Extending the timeout to 4 minutes makes sense to me because there are lots of conditions that need to be met for the test to succeed: * Prometheus instance configured as remote write receiver is running. * CMO propagates remote-write configuration to k8s Prometheus. * Prometheus operator generates the new Prometheus configuration. * config-reloader picks up the new configuration and reloads Prometheus. * Samples with the new label appear in the remote write receiver. [1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_prometheus/145/pull-ci-openshift-prometheus-master-e2e-agnostic-cmo/1592089698631684096/artifacts/e2e-agnostic-cmo/test/build-log.txt
@openshift-cherrypick-robot: Jira Issue OCPBUGS-4024 has been cloned as Jira Issue OCPBUGS-4029. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4029, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/skip |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label backport-risk-assessed |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-4029 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1817
/assign simonpasquier