New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-1626: Update jsonnet dependencies #1915
OCPBUGS-1626: Update jsonnet dependencies #1915
Conversation
Hi @openshift-monitoring-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label ok-to-test |
@raptorsun: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, openshift-monitoring-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
481fbca
to
4cc9d84
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/ok-to-test
we need to check that the alerts with additional selectors are working as expected.
4cc9d84
to
90b0ef9
Compare
90b0ef9
to
529b48a
Compare
529b48a
to
5f5383d
Compare
/retest-required |
5f5383d
to
452fe13
Compare
452fe13
to
e602196
Compare
e602196
to
3294e30
Compare
@@ -436,9 +436,9 @@ spec: | |||
}}' is experiencing {{ $value | humanizePercentage }} errors.' | |||
summary: Kubernetes API server client is experiencing errors. | |||
expr: | | |||
(sum(rate(rest_client_requests_total{code=~"5.."}[5m])) by (cluster, instance, job, namespace) | |||
(sum(rate(rest_client_requests_total{job="apiserver",code=~"5.."}[5m])) by (cluster, instance, job, namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there are metrics for the OpenShift API server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -436,9 +436,9 @@ spec: | |||
}}' is experiencing {{ $value | humanizePercentage }} errors.' | |||
summary: Kubernetes API server client is experiencing errors. | |||
expr: | | |||
(sum(rate(rest_client_requests_total{code=~"5.."}[5m])) by (cluster, instance, job, namespace) | |||
(sum(rate(rest_client_requests_total{job="apiserver",code=~"5.."}[5m])) by (cluster, instance, job, namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the alerting rule should be moved to openshift/cluster-apiserver-operator?
3294e30
to
70e53e4
Compare
/retitle OCPBUGS-1626: Update jsonnet dependencies |
@openshift-monitoring-bot[bot]: This pull request references Jira Issue OCPBUGS-1626, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/skip |
@simonpasquier: Cannot get combined commit statuses for PR #1915 in openshift/cluster-monitoring-operator: return code not 2XX: 500 Internal Server Error In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
superseded by #1961 |
70e53e4
to
bb07356
Compare
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bb07356
to
12a2a1c
Compare
@openshift-monitoring-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@simonpasquier: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-monitoring-bot[bot]: This pull request references Jira Issue OCPBUGS-1626. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This pull request updates all jsonnet dependencies listed in
jsonnet/jsonnetfile.json
to their latest versions and regenerates all assets.If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository: