Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-1626: Update jsonnet dependencies #1915

Conversation

openshift-monitoring-bot[bot]
Copy link

Description

This pull request updates all jsonnet dependencies listed in jsonnet/jsonnetfile.json to their latest versions and regenerates all assets.

If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository:

make update
make generate

@openshift-ci openshift-ci bot requested review from raptorsun and sthaha March 13, 2023 01:45
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raptorsun
Copy link
Contributor

/label ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

@raptorsun: The label(s) /label ok-to-test cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jan--f
Copy link
Contributor

jan--f commented Mar 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, openshift-monitoring-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@raptorsun
Copy link
Contributor

/retest-required

@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 481fbca to 4cc9d84 Compare March 20, 2023 01:45
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/ok-to-test
we need to check that the alerts with additional selectors are working as expected.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 4cc9d84 to 90b0ef9 Compare March 27, 2023 01:37
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 90b0ef9 to 529b48a Compare April 3, 2023 01:28
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 529b48a to 5f5383d Compare April 10, 2023 01:28
@raptorsun
Copy link
Contributor

/retest-required

@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 5f5383d to 452fe13 Compare April 17, 2023 01:29
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 452fe13 to e602196 Compare April 24, 2023 01:39
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from e602196 to 3294e30 Compare May 1, 2023 01:39
@@ -436,9 +436,9 @@ spec:
}}' is experiencing {{ $value | humanizePercentage }} errors.'
summary: Kubernetes API server client is experiencing errors.
expr: |
(sum(rate(rest_client_requests_total{code=~"5.."}[5m])) by (cluster, instance, job, namespace)
(sum(rate(rest_client_requests_total{job="apiserver",code=~"5.."}[5m])) by (cluster, instance, job, namespace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe there are metrics for the OpenShift API server?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -436,9 +436,9 @@ spec:
}}' is experiencing {{ $value | humanizePercentage }} errors.'
summary: Kubernetes API server client is experiencing errors.
expr: |
(sum(rate(rest_client_requests_total{code=~"5.."}[5m])) by (cluster, instance, job, namespace)
(sum(rate(rest_client_requests_total{job="apiserver",code=~"5.."}[5m])) by (cluster, instance, job, namespace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the alerting rule should be moved to openshift/cluster-apiserver-operator?

@simonpasquier
Copy link
Contributor

/retitle OCPBUGS-1626: Update jsonnet dependencies

@openshift-ci openshift-ci bot changed the title [bot] Update jsonnet dependencies OCPBUGS-1626: Update jsonnet dependencies May 9, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 9, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-monitoring-bot[bot]: This pull request references Jira Issue OCPBUGS-1626, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

This pull request updates all jsonnet dependencies listed in jsonnet/jsonnetfile.json to their latest versions and regenerates all assets.

If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository:

make update
make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao May 9, 2023 12:13
@simonpasquier
Copy link
Contributor

/skip
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@simonpasquier: Cannot get combined commit statuses for PR #1915 in openshift/cluster-monitoring-operator: return code not 2XX: 500 Internal Server Error

In response to this:

/skip
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

superseded by #1961

@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from 70e53e4 to bb07356 Compare May 15, 2023 01:39
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-update-generate branch from bb07356 to 12a2a1c Compare May 22, 2023 01:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@openshift-monitoring-bot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 12a2a1c link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-agnostic-operator 12a2a1c link true /test e2e-agnostic-operator
ci/prow/e2e-aws-ovn 12a2a1c link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node 12a2a1c link false /test e2e-aws-ovn-single-node
ci/prow/verify 12a2a1c link true /test verify
ci/prow/versions 12a2a1c link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@simonpasquier: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-monitoring-bot[bot]: This pull request references Jira Issue OCPBUGS-1626. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Description

This pull request updates all jsonnet dependencies listed in jsonnet/jsonnetfile.json to their latest versions and regenerates all assets.

If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository:

make update
make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants