Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-1626: update jsonnet dependencies #1961

Merged
merged 4 commits into from May 26, 2023
Merged

OCPBUGS-1626: update jsonnet dependencies #1961

merged 4 commits into from May 26, 2023

Conversation

simonpasquier
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This PR builds on top of #1915 which is the pull request generated by openshift-monitoring-bot. In addition to the normal jsonnet bumps, I made changes to avoid shipping the ScrapeConfig and PrometheusAgent artefacts since they are not supported within CMO.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 10, 2023
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request references Jira Issue OCPBUGS-1626, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This PR builds on top of #1915 which is the pull request generated by openshift-monitoring-bot. In addition to the normal jsonnet bumps, I made changes to avoid shipping the ScrapeConfig and PrometheusAgent artefacts since they are not supported within CMO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 10, 2023
@openshift-ci openshift-ci bot requested a review from juzhao May 10, 2023 08:45
@simonpasquier simonpasquier mentioned this pull request May 10, 2023
Closed
@openshift-ci openshift-ci bot requested review from raptorsun and slashpai May 10, 2023 08:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@slashpai
Copy link
Member

/retest

@simonpasquier
Copy link
Contributor Author

/skip

@simonpasquier
Copy link
Contributor Author

/retest

@simonpasquier simonpasquier mentioned this pull request May 10, 2023
Merged
@slashpai
Copy link
Member

/lgtm

@slashpai
Copy link
Member

/test e2e-agnostic-operator

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d1179dc and 2 for PR HEAD d50ecc3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d0dad7c and 1 for PR HEAD d50ecc3 in total

@slashpai
Copy link
Member

/retest

1 similar comment
@simonpasquier
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@simonpasquier
Copy link
Contributor Author

/skip

@simonpasquier
Copy link
Contributor Author

/retest

@slashpai
Copy link
Member

/lgtm

@slashpai
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d0dad7c and 2 for PR HEAD ec55c2c in total

@simonpasquier
Copy link
Contributor Author

/test e2e-agnostic-operator

2 similar comments
@simonpasquier
Copy link
Contributor Author

/test e2e-agnostic-operator

@simonpasquier
Copy link
Contributor Author

/test e2e-agnostic-operator

@simonpasquier
Copy link
Contributor Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@simonpasquier: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor Author

/retest-required

@slashpai
Copy link
Member

/test e2e-agnostic-operator

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d60d38 and 1 for PR HEAD ec55c2c in total

@simonpasquier
Copy link
Contributor Author

/retest-required

@simonpasquier
Copy link
Contributor Author

/test e2e-agnostic-cmo

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@simonpasquier: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-agnostic-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test generate
  • /test go-fmt
  • /test images
  • /test jsonnet-fmt
  • /test rules
  • /test shellcheck
  • /test unit
  • /test vendor
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn-single-node
  • /test versions

Use /test all to run all jobs.

In response to this:

/test e2e-agnostic-cmo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member

/test e2e-agnostic-operator

github-actions bot and others added 4 commits May 25, 2023 14:21
@github-actions @simonpasquier
[bot] Update jsonnet dependencies
780ad74 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@simonpasquier
jsonnet: remove PrometheusAgent and ScrapeConfig artefacts
95ef759 
This change removes the manifests deploying the PrometheusAgent and
ScrapeConfig CRDs because they are not supported by CMO. It also removes
the RBAC permissions associated with them.
@simonpasquier
jsonnet: ensure '--no-collector.hwmon' is set only once
dda5f2a
@simonpasquier
*: regenerate
9e14270 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@slashpai slashpai mentioned this pull request May 25, 2023
Closed
@simonpasquier
Copy link
Contributor Author

/test e2e-agnostic-operator

@simonpasquier
Copy link
Contributor Author

/skip

@slashpai
Copy link
Member

/test e2e-agnostic-operator

@slashpai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 9e14270 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 88d97c8 into openshift:master May 26, 2023
15 checks passed
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: Jira Issue OCPBUGS-1626: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-1626 has not been moved to the MODIFIED state.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This PR builds on top of #1915 which is the pull request generated by openshift-monitoring-bot. In addition to the normal jsonnet bumps, I made changes to avoid shipping the ScrapeConfig and PrometheusAgent artefacts since they are not supported within CMO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@slashpai slashpai slashpai approved these changes

@juzhao juzhao Awaiting requested review from juzhao

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@slashpai slashpai

@marioferh marioferh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simonpasquier @openshift-ci-robot @slashpai @marioferh @openshift-merge-robot