New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-19059: Enable ipv6 on monitoring-plugin nginx #2090
OCPBUGS-19059: Enable ipv6 on monitoring-plugin nginx #2090
Conversation
This commit modifies the monitoring-plugin configmap so nginx listens on both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it wasn't enabled on the endpoint config. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@danielmellado: This pull request references Jira Issue OCPBUGS-19059, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@danielmellado: This pull request references Jira Issue OCPBUGS-19059, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @simonpasquier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Additional question: how can we ensure with e2e tests that the console -> monitoring plugin communication works as expected?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll take a look at the current tests and see how feasible is to address that in a follow up patch, thanks! |
/skip I'd expect the test to live in openshift/origin. Probably need to sync with the console team too as it looks like a generic check for all console plugins. |
I will do a regression test for that |
@danielmellado: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cf64ee0
into
openshift:master
@danielmellado: Jira Issue OCPBUGS-19059: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-19059 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.14 |
@simonpasquier: new pull request created: #2091 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh. |
/jira refresh |
@simonpasquier: Jira Issue OCPBUGS-19059: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19059 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OCPBUGS-19059: Enable ipv6 on monitoring-plugin nginx
This commit modifies the monitoring-plugin configmap so nginx listens on
both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it
wasn't enabled on the endpoint config.
Signed-off-by: Daniel Mellado dmellado@redhat.com