Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19059: Enable ipv6 on monitoring-plugin nginx #2090

Merged

Conversation

danielmellado
Copy link
Contributor

This commit modifies the monitoring-plugin configmap so nginx listens on
both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it
wasn't enabled on the endpoint config.

Signed-off-by: Daniel Mellado dmellado@redhat.com

This commit modifies the monitoring-plugin configmap so nginx listens on
both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it
wasn't enabled on the endpoint config.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-19059, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit modifies the monitoring-plugin configmap so nginx listens on
both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it
wasn't enabled on the endpoint config.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado
Copy link
Contributor Author

/jira refresh

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-19059, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado
Copy link
Contributor Author

/cc @simonpasquier

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Additional question: how can we ensure with e2e tests that the console -> monitoring plugin communication works as expected?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielmellado
Copy link
Contributor Author

/lgtm

Additional question: how can we ensure with e2e tests that the console -> monitoring plugin communication works as expected?

I'll take a look at the current tests and see how feasible is to address that in a follow up patch, thanks!

@simonpasquier
Copy link
Contributor

/skip

I'd expect the test to live in openshift/origin. Probably need to sync with the console team too as it looks like a generic check for all console plugins.

@Tai-RedHat
Copy link

/lgtm

Additional question: how can we ensure with e2e tests that the console -> monitoring plugin communication works as expected?

I will do a regression test for that

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 36ce4cb link false /test versions
ci/prow/e2e-aws-ovn-single-node 36ce4cb link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cf64ee0 into openshift:master Sep 19, 2023
15 of 16 checks passed
@openshift-ci-robot
Copy link
Contributor

@danielmellado: Jira Issue OCPBUGS-19059: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-19059 has not been moved to the MODIFIED state.

In response to this:

This commit modifies the monitoring-plugin configmap so nginx listens on
both ipv4 and ipv6 addresses. The nginx image used supported ipv6 but it
wasn't enabled on the endpoint config.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot

@simonpasquier: new pull request created: #2091

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/jira refresh.

@simonpasquier
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: Jira Issue OCPBUGS-19059: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19059 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marioferh pushed a commit to marioferh/cluster-monitoring-operator that referenced this pull request Sep 25, 2023
OCPBUGS-19059: Enable ipv6 on monitoring-plugin nginx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants