Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19367: Console should not panic when no response is retrieved for plugin assets #13166

Merged
merged 1 commit into from Sep 22, 2023
Merged

OCPBUGS-19367: Console should not panic when no response is retrieved for plugin assets #13166

merged 1 commit into from Sep 22, 2023

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Sep 19, 2023

This can happen in case ipv6 is enabled on the cluster.

/assign @TheRealJon

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-19059, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This can happen in case ipv6 is enabled on the cluster.

/assign @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/backend Related to backend approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2023
This was referenced Sep 19, 2023
Merged
Merged
spadgett
spadgett reviewed Sep 19, 2023
View reviewed changes
pkg/plugins/handlers.go Outdated Show resolved Hide resolved
pkg/plugins/handlers.go Outdated Show resolved Hide resolved
spadgett
spadgett requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like the error is on this line:

https://github.com/openshift/console/blob/master/pkg/plugins/handlers.go#L165

Where we get an err but try to use resp when handling the error

@jhadvig
Copy link
Member Author

jhadvig commented Sep 19, 2023

@spadgett you are right, I've update the PR accordingly

spadgett
spadgett reviewed Sep 19, 2023
View reviewed changes
pkg/plugins/handlers.go Outdated
klog.Error(errMsg)
serverutils.SendResponse(w, resp.StatusCode, serverutils.ApiError{Err: errMsg})
serverutils.SendResponse(w, http.StatusInternalServerError, serverutils.ApiError{Err: errMsg})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

502 bad gateway is probably a better status code here

@simonpasquier
Copy link
Contributor

/retitle OCPBUGS-19367: Console should not panic when no response is retrieved for plugin assets

@openshift-ci openshift-ci bot changed the title OCPBUGS-19059: Console should not panic when no response is retrieved for plugin assets OCPBUGS-19367: Console should not panic when no response is retrieved for plugin assets Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-19367, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This can happen in case ipv6 is enabled on the cluster.

/assign @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/jira refresh

@jhadvig
Copy link
Member Author

jhadvig commented Sep 20, 2023

@spadgett comment addressed

spadgett
spadgett approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 20, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Jira Issue OCPBUGS-19367, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bae2dea and 2 for PR HEAD ccfef54 in total

@jhadvig
Copy link
Member Author

jhadvig commented Sep 21, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 114258d and 1 for PR HEAD ccfef54 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2935f7e into openshift:master Sep 22, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue OCPBUGS-19367: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19367 has been moved to the MODIFIED state.

In response to this:

This can happen in case ipv6 is enabled on the cluster.

/assign @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

@danielmellado
Copy link

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@danielmellado: new pull request created: #13217

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@Tai-RedHat Tai-RedHat Awaiting requested review from Tai-RedHat

@florkbr florkbr Awaiting requested review from florkbr

Assignees

@spadgett spadgett

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jhadvig @openshift-ci-robot @simonpasquier @spadgett @openshift-merge-robot @danielmellado @openshift-cherrypick-robot @TheRealJon