Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add -e to go list command to install tools #2112

Merged
merged 1 commit into from Oct 9, 2023

Commits on Oct 9, 2023

  1. build: add -e to go list command to install tools

    we rely on go imports to install our build tooling via hack/tools/go.mod.
    Some of these imports don't actually import valid modules since
    `package main` is used in some of them (e.g.
    https://github.com/brancz/gojsontoyaml/blob/6ffa820a00533125ad1c3f77d0429e4cac6f7072/main.go#L1).
    With go1.21 the `list` command will fail on those. Adding `-e` fixes
    this. I think this flag exists in older go version too, so this should
    work without being aware of the version.
    
    Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
    jan--f committed Oct 9, 2023
    Copy the full SHA
    212b58d View commit details
    Browse the repository at this point in the history