build: add -e to go list command to install tools
#2112
Conversation
we rely on go imports to install our build tooling via hack/tools/go.mod. Some of these imports don't actually import valid modules since `package main` is used in some of them (e.g. https://github.com/brancz/gojsontoyaml/blob/6ffa820a00533125ad1c3f77d0429e4cac6f7072/main.go#L1). With go1.21 the `list` command will fail on those. Adding `-e` fixes this. I think this flag exists in older go version too, so this should work without being aware of the version. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
openshift-ci
bot
added
the
approved
|
/cc @simonpasquier |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jan--f: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
we rely on go imports to install our build tooling via hack/tools/go.mod. Some of these imports don't actually import valid modules since
package mainis used in some of them (e.g.https://github.com/brancz/gojsontoyaml/blob/6ffa820a00533125ad1c3f77d0429e4cac6f7072/main.go#L1). With go1.21 the
listcommand will fail on those. Adding-efixes this. I think this flag exists in older go version too, so this should work without being aware of the version.\cc @simonpasquier