Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-21610: Change config to allow ipv6/4 #2166

Merged
merged 1 commit into from Nov 27, 2023
Merged

OCPBUGS-21610: Change config to allow ipv6/4 #2166

merged 1 commit into from Nov 27, 2023

Conversation

danielmellado
Copy link
Contributor

@danielmellado danielmellado commented Nov 23, 2023 •
edited

This commit uses the Kube Downward API to get the plugin's pod
status.podIP and bash to set it and run nginx accordingly. This is also
set in the jsonnet so it gets generated, even though it's some kind of
double templating.

Signed-off-by: Daniel Mellado dmellado@redhat.com

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 23, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-21610, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit uses the Kube Downward API to get the plugin's pod
status.podIP and bash to set it and run nginx accordingly. This is also
set in the jsonnet so it gets generated, even though it's some kind of
double templating.

Signed-off-by: Daniel Mellado dmellado@redhat.com

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 23, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-21610, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 23, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-21610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

In response to this:

This commit uses the Kube Downward API to get the plugin's pod
status.podIP and bash to set it and run nginx accordingly. This is also
set in the jsonnet so it gets generated, even though it's some kind of
double templating.

Signed-off-by: Daniel Mellado dmellado@redhat.com

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado danielmellado force-pushed the monitoring_console_ipv6_remove branch 2 times, most recently from 4bbc81f to 21a178f Compare November 23, 2023 12:30
@danielmellado
Copy link
Contributor Author

/retest-required

1 similar comment
@danielmellado
Copy link
Contributor Author

/retest-required

@machine424 machine424 mentioned this pull request Nov 24, 2023
Closed
2 tasks
@danielmellado
OCPBUGS-21610: Change config to allow ipv6/4
0ee8922 
This commit uses the Kube Downward API to get the plugin's pod
status.podIP and bash to set it and run nginx accordingly. This is also
set in the jsonnet so it gets generated, even though it's some kind of
double templating.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@danielmellado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 0ee8922 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1af6396 and 2 for PR HEAD 0ee8922 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 958ddf0 into openshift:master Nov 27, 2023
16 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@danielmellado: Jira Issue OCPBUGS-21610: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21610 has been moved to the MODIFIED state.

In response to this:

This commit uses the Kube Downward API to get the plugin's pod
status.podIP and bash to set it and run nginx accordingly. This is also
set in the jsonnet so it gets generated, even though it's some kind of
double templating.

Signed-off-by: Daniel Mellado dmellado@redhat.com

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202311272131.p0.g958ddf0.assembly.stream for distgit cluster-monitoring-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-28-101923

simonpasquier
simonpasquier reviewed Nov 30, 2023
View reviewed changes
assets/monitoring-plugin/deployment.yaml
- -c
- |
if echo "$POD_IP" | grep -qE '^([0-9]{1,3}\.){3}[0-9]{1,3}$'; then
LISTEN_ADDRESS_PORT_REPLACED_AT_RUNTIME="9943"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9943 should have been 9443

@simonpasquier simonpasquier mentioned this pull request Nov 30, 2023
Merged
openshift-merge-bot bot added a commit that referenced this pull request Nov 30, 2023
@openshift-merge-bot
Merge pull request #2172 from danielmellado/revert_allow_ipv6_4
7dc0037 
OCPBUGS-21610: revert #2166
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 7, 2023
Merged
2 tasks
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-08-202155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@raptorsun raptorsun raptorsun left review comments

@machine424 machine424 machine424 left review comments

@Tai-RedHat Tai-RedHat Awaiting requested review from Tai-RedHat

@slashpai slashpai Awaiting requested review from slashpai

Assignees

@raptorsun raptorsun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danielmellado @openshift-ci-robot @raptorsun @openshift-bot @openshift-merge-robot @simonpasquier @machine424