Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21610: revert #2166 #2172

Merged

Conversation

danielmellado
Copy link
Contributor

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

------------------------ >8 ------------------------

Do not modify or remove the line above.
Everything below it will be ignored.

Revert "OCPBUGS-21610: Change config to allow ipv6/4"

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado dmellado@redhat.com

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-21610, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

------------------------ >8 ------------------------

Do not modify or remove the line above.
Everything below it will be ignored.

Revert "OCPBUGS-21610: Change config to allow ipv6/4"

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@danielmellado danielmellado changed the title Revert "OCPBUGS-21610: Change config to allow ipv6/4" Revert "21610: Change config to allow ipv6/4" Nov 30, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

------------------------ >8 ------------------------

Do not modify or remove the line above.
Everything below it will be ignored.

Revert "OCPBUGS-21610: Change config to allow ipv6/4"

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424
Copy link
Contributor

as it's creating issues with the monitoring UI.

Could I know more?

@machine424
Copy link
Contributor

I found the slack thread, we'll need some tests if we decide to put it back :)

@simonpasquier
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/retitle OCPBUGS-21610: revert #2166

@openshift-ci openshift-ci bot changed the title Revert "21610: Change config to allow ipv6/4" OCPBUGS-21610: revert #2166 Nov 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-21610, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

------------------------ >8 ------------------------

Do not modify or remove the line above.
Everything below it will be ignored.

Revert "OCPBUGS-21610: Change config to allow ipv6/4"

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e39355c and 2 for PR HEAD e4e3195 in total

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@danielmellado: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7dc0037 into openshift:master Nov 30, 2023
17 checks passed
@openshift-ci-robot
Copy link
Contributor

@danielmellado: Jira Issue OCPBUGS-21610: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21610 has been moved to the MODIFIED state.

In response to this:

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

------------------------ >8 ------------------------

Do not modify or remove the line above.
Everything below it will be ignored.

Revert "OCPBUGS-21610: Change config to allow ipv6/4"

This reverts commit 0ee8922.
as it's creating issues with the monitoring UI.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202312010209.p0.g7dc0037.assembly.stream for distgit cluster-monitoring-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-08-202155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants