Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2100: jsonnet: update crio port to TLS port 9637 #2257

Merged

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Feb 7, 2024

This PR switches monitoring over to use the secure 9637 metrics port for crio (backed by kube-rbac-proxy). It also changes the authentication to use the client certificate auth, since static pods cannot mount secrets.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2024

@rphillips: This pull request references OCPNODE-2022 which is a valid jira issue.

In response to this:

This reverts commit ee97565.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
@rphillips
Copy link
Contributor Author

/payload help

@rphillips
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

@rphillips
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c020710-c5c5-11ee-922b-dca000ede010-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/820f5280-c6d5-11ee-97cb-3e05c7124d92-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

1 similar comment
@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/896bb770-c93d-11ee-8788-320a5f153a65-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d734920-c9ca-11ee-824a-026157b75804-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56f50e00-ca7c-11ee-974b-7cd8f62e7155-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71d442f0-d03e-11ee-95a3-a9525782e9b1-0

@rphillips
Copy link
Contributor Author

Another set of test runs:

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ee6ad150-d046-11ee-8944-22e78ea98d14-0

@sairameshv
Copy link
Member

Trying out the payload test on a new PR

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4209

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4209

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/947aaa00-d0bc-11ee-8a88-f4397baa2cbc-0

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2fe383e0-d0bd-11ee-810a-f5690c54df5d-0

@rphillips rphillips changed the title jsonnet: update crio port to TLS port 9637 OCPNODE-2100: jsonnet: update crio port to TLS port 9637 Mar 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2100 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@rphillips
Copy link
Contributor Author

/hold for openshift/machine-config-operator#4175

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 1c0aa30 link false /test versions
ci/prow/e2e-aws-ovn-single-node 1c0aa30 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@rphillips: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@rphillips
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b0a66fe0-e005-11ee-9e0d-e60f3f7a9b45-0

@rphillips
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0001cb10-e07f-11ee-9aca-a93d433e5341-0

@rphillips
Copy link
Contributor Author

This should be testing with 4.15.3 now (with crio static pods)

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0e213a50-e09d-11ee-9437-435f617d856c-0

@rphillips
Copy link
Contributor Author

Test passed from 4.15 to master... I need to get 2 more PRs into 4.14 so that EUS upgrades work.

@rphillips
Copy link
Contributor Author

4.14 merged.

This PR is now ready.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024

@rphillips: This pull request references OCPNODE-2100 which is a valid jira issue.

In response to this:

This PR switches monitoring over to use the secure 9637 metrics port for crio (backed by kube-rbac-proxy). It also changes the authentication to use the client certificate auth, since static pods cannot mount secrets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor Author

/retest-required

@danielmellado
Copy link
Contributor

/lgtm thanks!

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
Copy link

@harche harche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, harche, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e761b9e into openshift:master Mar 23, 2024
15 of 17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202403230015.p0.ge761b9e.assembly.stream.el9 for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants