Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2099: add kube-rbac-proxy-crio toleration change #28636

Merged

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Mar 5, 2024

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

After all the above backports are merged, then

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips rphillips changed the title OCPNODE-2099: add kube-rbac-proxy toleration change OCPNODE-2099: add kube-rbac-proxy-crio toleration change Mar 5, 2024
@openshift-ci openshift-ci bot requested review from deads2k and sdodson March 5, 2024 16:09
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

This PR will need to be backported to EUS 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor Author

/assign @deads2k

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

Allow the static pod tolerations within origin tests (this PR)

4.16/master : Backport to 4.14

MCO Kube-Rbac-Proxy Static pods

4.16/master : openshift/machine-config-operator#4175 : Backport EUS 4.14

After all the above backports are done, then merge

change the Monitoring Operator to use port 9637 (with client certificates)

openshift/cluster-monitoring-operator#2257 : This PR is only for 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

Allow the static pod tolerations within origin tests (this PR)

4.16/master : Backport to 4.14

MCO Kube-Rbac-Proxy Static pods

4.16/master : openshift/machine-config-operator#4175 : Backport EUS 4.14

After all the above backports are done, then

change the Monitoring Operator to use port 9637 (with client certificates)

openshift/cluster-monitoring-operator#2257 : This PR is only for 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

After all the above backports are merged, then

  • Change the Monitoring Operator to use port 9637 (with client certificates)

openshift/cluster-monitoring-operator#2257 : This PR is only for 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

After all the above backports are merged, then

  • Change the Monitoring Operator to use port 9637 (with client certificates)

openshift/cluster-monitoring-operator#2257 : This PR is only for 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@rphillips: This pull request references OCPNODE-2099 which is a valid jira issue.

In response to this:

kube-rbac-proxy-crio is a new static pod in the openshift-machine-config-operator namespace. Since it is a static pod, the tolerations test needs to ignore this pod due to it tolerating all taints.

openshift-machine-config-operator/kube-rbac-proxy-crio-ip-10-0-112-244.us-west-2.compute.internal tolerates all taints

Merge information

After all the above backports are merged, then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2024

/lgtm
/approve

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade c759a19 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-sdn c759a19 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node c759a19 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial c759a19 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ba887b4 into openshift:master Mar 6, 2024
18 of 22 checks passed
@openshift-cherrypick-robot

@rphillips: new pull request created: #28637

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403060709.p0.gba887b4.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants