Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add -e to fix make generate #2276

Closed

Conversation

marioferh
Copy link
Contributor

With new go versions this error apperas:

cluster-monitoring-operator git:(master) make generate                                                                                                     
Installing tools from hack/tools.go                                                                                                                           
tools.go:22:2: import "github.com/brancz/gojsontoyaml" is a program, not an importable package           

In order to fix id an -e is added to make generate. Related #2112

@marioferh marioferh changed the title build: add -e to fix make generate with new go versions build: add -e to fix make generate Mar 7, 2024
@openshift-ci openshift-ci bot requested review from rexagod and slashpai March 7, 2024 09:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@marioferh marioferh closed this Mar 7, 2024
@marioferh marioferh force-pushed the fix_make_generate_importable_pkg branch from e2a1116 to 5342dee Compare March 7, 2024 09:19
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marioferh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-operator 5342dee link true /test e2e-agnostic-operator
ci/prow/e2e-aws-ovn-single-node 5342dee link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-techpreview 5342dee link true /test e2e-aws-ovn-techpreview
ci/prow/versions 5342dee link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant