Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1711073: jsonnet: add resource requests #356

Merged
merged 1 commit into from
May 17, 2019

Conversation

paulfantom
Copy link
Contributor

@paulfantom paulfantom commented May 17, 2019

Add resource requests to monitoring stack components.

Relates to openshift/origin#22787

/cc: @brancz @metalmatze @s-urbaniak @squat

@paulfantom paulfantom changed the title Bug 1711073: jsonnet: add resources requests Bug 1711073: jsonnet: add resource requests May 17, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2019
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@brancz
Copy link
Contributor

brancz commented May 17, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, metalmatze, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 60e6a5b into openshift:master May 17, 2019
@paulfantom paulfantom deleted the resources branch May 17, 2019 19:55
@sjenning
Copy link
Contributor

ah ok, this was not right. Resources is a Container field, not a Pod field.

@paulfantom
Copy link
Contributor Author

Right, I will fix this soon.

paulfantom added a commit to paulfantom/cluster-monitoring-operator that referenced this pull request May 29, 2019
paulfantom added a commit to paulfantom/cluster-monitoring-operator that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants