Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Add ingress related recording rules for OpenShift #406

Merged
merged 1 commit into from Jul 20, 2019

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jul 18, 2019

Summarize the key metrics for the platform for USE on the ingress
controllers - specifically the error rates for HTTP based traffic
and the incoming and outgoing bandwidth, and session concurrency.

@ironcladlou

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2019
@ironcladlou
Copy link
Contributor

Looks great to me, this is a big head start for us

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2019
jsonnet/rules.jsonnet Outdated Show resolved Hide resolved
Summarize the key metrics for the platform for USE on the ingress
controllers - specifically the error rates for HTTP based traffic
and the incoming and outgoing bandwidth, and session concurrency.
@smarterclayton
Copy link
Contributor Author

/retest

@brancz
Copy link
Contributor

brancz commented Jul 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1d3a2dc into openshift:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants