Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794616: replace up with count:up[0,1], remove node_uname_info #650

Merged
merged 6 commits into from Feb 10, 2020
Merged

Bug 1794616: replace up with count:up[0,1], remove node_uname_info #650

merged 6 commits into from Feb 10, 2020

Conversation

s-urbaniak
Copy link
Contributor

This reduces size for the up metric by replacing it with count:up0 and count:up1 recording rules and removes node_uname_info as it is unused.

Once we reach final consensus here especially with @smarterclayton this will be backported to 4.3.

/cc @smarterclayton @openshift/openshift-team-monitoring

@s-urbaniak
jsonnet/jsonnetfile.lock.json: bump kube-prometheus
2cd2f80
@s-urbaniak
assets: regenerate
41189cb
@s-urbaniak
manifests/telemetry: replace up with count:up0/count:up1
fac9114 
Currently the up metric size grows linearly with the node size.
This fixes it by replacing it with count recording rules.
@s-urbaniak
Documentation: regenerate
849eb29
@s-urbaniak
manifests/telemetry: remove node_uname_info
2d5a869 
node_uname_info is not needed any more
and its size grows linearly with cluster size.

This fixes it by removing it.
@s-urbaniak
Documentation: regenerate
35f7ecc
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1794616, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1794616: replace up with count:up[0,1], remove node_uname_info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2020
simonpasquier
simonpasquier reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 58179c5 into openshift:master Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: All pull requests linked via external trackers have merged. Bugzilla bug 1794616 has been moved to the MODIFIED state.

In response to this:

Bug 1794616: replace up with count:up[0,1], remove node_uname_info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the up-down branch February 10, 2020 11:36
@s-urbaniak
Copy link
Contributor Author

Whoops, i actually wanted /hold it, until we reach final consensus, my bad. We can always revert if we find problems with the recording rules here.

@brancz
Copy link
Contributor

brancz commented Feb 10, 2020

happy with this

@lilic
Copy link
Contributor

lilic commented Feb 10, 2020

Do we need to tell whoever added that info metric that we removed it?

@brancz
Copy link
Contributor

brancz commented Feb 10, 2020

yeah probably a good idea :)

@lilic
Copy link
Contributor

lilic commented Feb 10, 2020

Opened https://issues.redhat.com/browse/MON-970 to make this easier in the future.

@s-urbaniak
Copy link
Contributor Author

The removal of the info metric was synced with @smarterclayton though as he was shepherding its removal in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@s-urbaniak @openshift-ci-robot @brancz @lilic @simonpasquier @openshift-merge-robot