-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/manifests: remove Hostport from Thanos ruler config #734
pkg/manifests: remove Hostport from Thanos ruler config #734
Conversation
That would be @pgier so leaving up to him to review, but lgtm. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
I think we'll need this soon so holding for now :) |
After more thinking, we shouldn't need this hence: /unhold |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This isn't used anywhere and most probably a copy/paste from the Prometheus/Alertmanager configuration.
cc @pgier @lilic who worked on this part before.