Bug 1829974: pkg/tasks: remove grafana secret from thanos ruler #779
Conversation
The Grafana secret is not needed by Thanos Ruler. Also, make the variable names clearer and fix ordering of deleting resources.
|
@pgier: An error was encountered searching for bug 1829974 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/severity-high
|
@pgier: This pull request references Bugzilla bug 1829974, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, pgier, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pgier: All pull requests linked via external trackers have merged: openshift/cluster-monitoring-operator#777, openshift/cluster-monitoring-operator#779. Bugzilla bug 1829974 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pgier We seem to have e2e tests where we asserts assets are deleted, do you mind expanding on the expected cases there, not urgent, just would be good I think. Didn't catch it until now. Thanks! https://github.com/openshift/cluster-monitoring-operator/blob/master/test/e2e/user_workload_monitoring_test.go#L523 |
The Grafana secret is not needed by Thanos Ruler.
Also, make the variable names clearer and fix ordering of deleting
resources.