Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1819097: Removing 'Developer Preview' references from telemetry doc #907

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1819097: Removing 'Developer Preview' references from telemetry doc #907

merged 1 commit into from Aug 20, 2020

Conversation

pneedle-rh
Copy link
Contributor

@pneedle-rh pneedle-rh commented Aug 12, 2020 •
edited

Removing references to 'Developer Preview' from the 'OpenShift 4 Data Collection' document, now that OpenShift 4 is generally available.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This relates to the following:

Bug 1819097 - Telemetry Doc Still References "Developer Preview"
https://bugzilla.redhat.com/show_bug.cgi?id=1819097

[1819097] Telemetry Doc Still References "Developer Preview"
https://issues.redhat.com/browse/OCPBUGSM-1384

@paulfantom
Copy link
Contributor

/test generate

@pneedle-rh
Copy link
Contributor Author

@openshift/openshift-team-telemetry and @smarterclayton can you please review?

Can you also please confirm whether the introduction of the word 'anonymized' is suitable in the doc?

Thanks!

@juzhao
Copy link

juzhao commented Aug 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@s-urbaniak
Copy link
Contributor

/approve
/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

bwplotka
bwplotka approved these changes Aug 18, 2020
View reviewed changes
Copy link

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from telemeter team

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak
Copy link
Contributor

/hold
let me help with the generate target

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
s-urbaniak
s-urbaniak reviewed Aug 19, 2020
View reviewed changes
Documentation/data-collection.md Outdated
# the total amount of storage requested by PVCs from a particular storage provisioner in bytes.
- '{__name__="cluster:kube_persistentvolumeclaim_resource_requests_storage_bytes:provisioner:sum"}'
# cluster:kubelet_volume_stats_used_bytes:provisioner:sum will gives
# cluster:kubelet_volume_stats_used_bytes:provisioner:sum will gives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funky, the generate target wants to introduce the trailing whitespace. do you mind to add it back in ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-urbaniak I have now added the space back in. I did this by running make docs on my local clone, as per @paulfantom's guidance when this happened previously. That seems to refresh the embedded reference to ../manifests/0000_50_cluster_monitoring_operator_04-config.yaml within Documentation/data-collection.md.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@s-urbaniak
Copy link
Contributor

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwplotka, juzhao, pneedle-rh, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak s-urbaniak changed the title BZ1819097 - Removing 'Developer Preview' references from telemetry doc Bug 1819097: Removing 'Developer Preview' references from telemetry doc Aug 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@pneedle-rh: This pull request references Bugzilla bug 1819097, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1819097: Removing 'Developer Preview' references from telemetry doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2020
@s-urbaniak
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1819097, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1819097, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fbcb670 into openshift:master Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@pneedle-rh: All pull requests linked via external trackers have merged: openshift/cluster-monitoring-operator#907. Bugzilla bug 1819097 has been moved to the MODIFIED state.

In response to this:

Bug 1819097: Removing 'Developer Preview' references from telemetry doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak left review comments

@juzhao juzhao juzhao left review comments

@bwplotka bwplotka bwplotka approved these changes

@paulfantom paulfantom Awaiting requested review from paulfantom

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@s-urbaniak s-urbaniak

@juzhao juzhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pneedle-rh @paulfantom @juzhao @s-urbaniak @openshift-bot @openshift-ci-robot @bwplotka @openshift-merge-robot