Bug 1877735: Adding CodeReady Workspaces metrics to the allowlist / config.yaml #925
Conversation
Documentation/data-collection.md
Outdated
| @@ -225,6 +225,17 @@ data: | |||
| # (workloads-team, @openshift/openshift-group-b) cluster_master_schedulable reports whether mastersSchedulable=true in | |||
| # the scheduler operator. This value is a boolean 0|1 | |||
| - '{__name__="cluster_master_schedulable"}' | |||
| # (codeready workspaces) The number of workspaces with a given status STARTING|STOPPED|RUNNING|STOPPING. Type 'gauge'. | |||
There was a problem hiding this comment.
Please add a team (github alias) owning these metrics.
There was a problem hiding this comment.
the repo is under https://github.com/redhat-developer/codeready-workspaces I do not think we have some team alias
There was a problem hiding this comment.
We need some contact team internally who are responsible for those metrics.
There was a problem hiding this comment.
sure, but can it be an internal slack channel reference?
There was a problem hiding this comment.
No, its for pinging on github. Ideally a team within openshift org or individual person we can ping when we change/rename/remove metrics.
There was a problem hiding this comment.
@vparfonov @ibuziuk please add a team alias in the openshift organization where we can ping people in case we run into troubles with those metrics.
|
cc @smarterclayton for approval |
|
side note: You need a bugzilla as we are in feature freeze cycle in OpenShift too. |
|
ah, i see cardinality has been approved in the linked doc, ok 👍 |
|
/test e2e-aws-operator |
if we can make it for 4.6 that would be ideal otherwise we plan to have it for 4.7 |
s-urbaniak
changed the title
openshift-ci-robot
added
bugzilla/severity-low
|
@ibuziuk: This pull request references Bugzilla bug 1877735, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
folks, I will be on PTO till September 29th, but @vparfonov will follow up on this PR. Please let us know if anything is required on our end to have these metrics in 4.6 |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@simonpasquier: This pull request references Bugzilla bug 1877735, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
one last nit regarding team alias, but I have one last question: @ibuziuk @vparfonov just to make sure: do we have e2e coverage in CI for those metrics too where we can inspect runtime behavior of prometheus, aka a downloadable metrics dump? |
@s-urbaniak AFAIK we don't have any test which covered such cases |
|
@vparfonov just verified with @lilic, you are covered by OLM tests. This LGTM minus some contact person/mailing-list alias/github team we can contact in case of issues with the metrics. |
|
@s-urbaniak Can we merge this PR as is, after add contact person/mailing-list in separate PR? |
|
@vparfonov no because you need another bugzilla for that, so would be best to do that now. 4.6 code freeze is a week or so away so you still have some time. :) You can also add yourself temporarily and fix in 4.7 to something else? |
|
/retest |
…onfig.yaml Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…rics Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com> Co-authored-by: Vitalii Parfonov <vparfono@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibuziuk, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ibuziuk: All pull requests linked via external trackers have merged: Bugzilla bug 1877735 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related CRW issue - https://issues.redhat.com/browse/CRW-927
CodeReady Workspaces team request for sending data via telemetry [Approved for cardinality] - https://docs.google.com/document/d/1WzJrXXCFSFVFLHIKeg0b-lo3wA4S1qPK4Qa7fKdjMKo/edit#heading=h.3im6egcwyu2
Changelog entry format: