Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JacobTanenbaum to list of approvers #1099

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

JacobTanenbaum
Copy link
Contributor

adding JacobTanenbaum to approvers

primarily so that I can approve CI testing changes

adding JacobTanenbaum to approvers
@JacobTanenbaum
Copy link
Contributor Author

@abhat @danwinship @dcbw @knobunc could you please comment on this?

1 similar comment
@JacobTanenbaum
Copy link
Contributor Author

@abhat @danwinship @dcbw @knobunc could you please comment on this?

@JacobTanenbaum
Copy link
Contributor Author

/retest

1 similar comment
@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

/restest

@knobunc
Copy link
Contributor

knobunc commented Jun 17, 2021

/approve

@knobunc
Copy link
Contributor

knobunc commented Jun 17, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-ovn 701b6cf link /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 701b6cf link /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-gcp-ovn-upgrade 701b6cf link /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-agnostic-upgrade

PR only modifies OWNERS. e2e is irrelevant

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-agnostic-upgrade

PR only modifies OWNERS. e2e is irrelevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 565088e into openshift:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants